From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8128 invoked by alias); 5 Apr 2010 22:24:00 -0000 Received: (qmail 8100 invoked by uid 22791); 5 Apr 2010 22:23:57 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Apr 2010 22:23:47 +0000 Received: (qmail 10752 invoked from network); 5 Apr 2010 22:23:45 -0000 Received: from unknown (HELO macbook-2.local) (stan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 5 Apr 2010 22:23:45 -0000 Message-ID: <4BBA62EC.7060601@codesourcery.com> Date: Mon, 05 Apr 2010 22:24:00 -0000 From: Stan Shebs User-Agent: Thunderbird 2.0.0.24 (Macintosh/20100228) MIME-Version: 1.0 To: Joel Brobecker CC: Stan Shebs , gdb-patches@sourceware.org Subject: Re: [PATCH] Use vectors in uploaded tracepoints References: <4BBA3E00.7060508@codesourcery.com> <20100405205028.GF19194@adacore.com> In-Reply-To: <20100405205028.GF19194@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00084.txt.bz2 Joel Brobecker wrote: >> 1. This is now the third place that has a "char_ptr" typedef for use >> with vectors. Is there any reason not to consolidate into one >> typedef in defs.h? >> > > Certainly no objection on this end, although the benefits seem to be > pretty small. Perhaps it would make even better sense if we added both > the char_ptr and the vector definition? Would that have any negative > effect in terms of amount of code? > My patch has to add the typedef to a .h file, so there's potential for future annoyance if the typedefs ever collide. The vector definition is probably harmless, although I'm generally reluctant to rely on the compiler + linker always doing the right thing with masses of static inline functions coming from headers. No doubt people will tell me I'm being paranoid, and the build would *never* fail with a complaint about duplicate symbols. :-) Stan