From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7913 invoked by alias); 29 Mar 2010 17:23:05 -0000 Received: (qmail 7902 invoked by uid 22791); 29 Mar 2010 17:23:04 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 29 Mar 2010 17:23:00 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2THMw2G031131 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 29 Mar 2010 13:22:58 -0400 Received: from [10.15.16.55] (toner.yyz.redhat.com [10.15.16.55]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2THMucJ002209; Mon, 29 Mar 2010 13:22:57 -0400 Message-ID: <4BB0E194.7060008@redhat.com> Date: Mon, 29 Mar 2010 17:23:00 -0000 From: Sami Wagiaalla User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Lightning/1.0b1 Thunderbird/3.0.1 MIME-Version: 1.0 To: tromey@redhat.com CC: gdb-patches@sourceware.org Subject: Re: [patch] Add support for imported declaration and correct search order References: <201003232135.o2NLZWXB002778@d12av02.megacenter.de.ibm.com> <4BB0BD59.7030104@redhat.com> In-Reply-To: Content-Type: multipart/mixed; boundary="------------020700030107070701030304" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg01009.txt.bz2 This is a multi-part message in MIME format. --------------020700030107070701030304 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1952 On 03/29/2010 12:33 PM, Tom Tromey wrote: >>>>>> "Sami" == Sami Wagiaalla writes: > > Sami> +if { [test_compiler_info {gcc-[0-3]-*}] || > Sami> + [test_compiler_info {gcc-4-[0-3]-*}]} { setup_xfail *-*-* } > > Split the second line here after the "{" and then again before the "}". > > Sami> +if { [test_compiler_info {gcc-[0-3]-*}] || > Sami> + [test_compiler_info {gcc-4-[0-3]-*}]} { setup_xfail *-*-* } > > Here too. > > Ok with this change. > Will commit this: 2010-03-29 Sami Wagiaalla * gdb.cp/nsusing.exp: Marked imported declaration test as xfail with gcc < 4.4. * gdb.cp/shadow.exp: Ditto. diff --git a/gdb/testsuite/gdb.cp/nsusing.exp b/gdb/testsuite/gdb.cp/nsusing.exp index b060ee2..718b4b8 100644 --- a/gdb/testsuite/gdb.cp/nsusing.exp +++ b/gdb/testsuite/gdb.cp/nsusing.exp @@ -206,5 +206,10 @@ if ![runto_main] then { gdb_breakpoint [gdb_get_line_number "marker10 stop"] gdb_continue_to_breakpoint "marker10 stop" +if { [test_compiler_info {gcc-[0-3]-*}] || + [test_compiler_info {gcc-4-[0-3]-*}]} { + setup_xfail *-*-* +} + # Assert that M::x is printed and not N::x gdb_test "print x" "= 911" "print x (from M::x)" diff --git a/gdb/testsuite/gdb.cp/shadow.exp b/gdb/testsuite/gdb.cp/shadow.exp index 40c35a4..945cf99 100644 --- a/gdb/testsuite/gdb.cp/shadow.exp +++ b/gdb/testsuite/gdb.cp/shadow.exp @@ -31,6 +31,10 @@ if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {deb return -1 } +if [get_compiler_info ${binfile}] { + return -1 +} + # Get things started. gdb_exit @@ -85,4 +89,9 @@ gdb_test "print x" "= 55" "Print local x not namespace x" gdb_breakpoint [gdb_get_line_number "marker5"] gdb_continue_to_breakpoint "marker5" +if { [test_compiler_info {gcc-[0-3]-*}] || + [test_compiler_info {gcc-4-[0-3]-*}]} { + setup_xfail *-*-* +} + gdb_test "print x" "= 11" "Print imported namespace x" --------------020700030107070701030304 Content-Type: text/plain; name="xfail.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="xfail.patch" Content-length: 1445 2010-03-29 Sami Wagiaalla * gdb.cp/nsusing.exp: Marked imported declaration test as xfail with gcc < 4.4. * gdb.cp/shadow.exp: Ditto. diff --git a/gdb/testsuite/gdb.cp/nsusing.exp b/gdb/testsuite/gdb.cp/nsusing.exp index b060ee2..718b4b8 100644 --- a/gdb/testsuite/gdb.cp/nsusing.exp +++ b/gdb/testsuite/gdb.cp/nsusing.exp @@ -206,5 +206,10 @@ if ![runto_main] then { gdb_breakpoint [gdb_get_line_number "marker10 stop"] gdb_continue_to_breakpoint "marker10 stop" +if { [test_compiler_info {gcc-[0-3]-*}] || + [test_compiler_info {gcc-4-[0-3]-*}]} { + setup_xfail *-*-* +} + # Assert that M::x is printed and not N::x gdb_test "print x" "= 911" "print x (from M::x)" diff --git a/gdb/testsuite/gdb.cp/shadow.exp b/gdb/testsuite/gdb.cp/shadow.exp index 40c35a4..945cf99 100644 --- a/gdb/testsuite/gdb.cp/shadow.exp +++ b/gdb/testsuite/gdb.cp/shadow.exp @@ -31,6 +31,10 @@ if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {deb return -1 } +if [get_compiler_info ${binfile}] { + return -1 +} + # Get things started. gdb_exit @@ -85,4 +89,9 @@ gdb_test "print x" "= 55" "Print local x not namespace x" gdb_breakpoint [gdb_get_line_number "marker5"] gdb_continue_to_breakpoint "marker5" +if { [test_compiler_info {gcc-[0-3]-*}] || + [test_compiler_info {gcc-4-[0-3]-*}]} { + setup_xfail *-*-* +} + gdb_test "print x" "= 11" "Print imported namespace x" --------------020700030107070701030304--