From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17293 invoked by alias); 22 Mar 2010 15:01:51 -0000 Received: (qmail 17134 invoked by uid 22791); 22 Mar 2010 15:01:50 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Mar 2010 15:01:36 +0000 Received: (qmail 2301 invoked from network); 22 Mar 2010 15:01:34 -0000 Received: from unknown (HELO macbook-2.local) (stan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 22 Mar 2010 15:01:34 -0000 Message-ID: <4BA78648.6090202@codesourcery.com> Date: Mon, 22 Mar 2010 15:01:00 -0000 From: Stan Shebs User-Agent: Thunderbird 2.0.0.24 (Macintosh/20100228) MIME-Version: 1.0 To: Vladimir Prus CC: Stan Shebs , gdb-patches@sourceware.org Subject: Re: [MI tracepoints 2/9] unify breakpoint commands and tracepoint actions References: <201003141147.34051.vladimir@codesourcery.com> <4B9E72C5.60303@codesourcery.com> <201003161438.27874.vladimir@codesourcery.com> In-Reply-To: <201003161438.27874.vladimir@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00757.txt.bz2 Vladimir Prus wrote: > Here's a revised version, also addressing Pedro's comments. > Looks great, just one little thing left to fix: + if (strstr (c->line, "eval ") == c->line) + error (_("The 'eval' command can only be used for tracepoints")); The command is now "teval" instead of "eval". With that change, we should be ready to roll in all 9 patches. Thanks again! Stan