From: Michael Snyder <msnyder@vmware.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Doug Evans <dje@google.com>,
"dan@codesourcery.com" <dan@codesourcery.com>
Subject: Re: [RFA] gdbserver, errno handling in my_waitpid
Date: Wed, 10 Mar 2010 21:48:00 -0000 [thread overview]
Message-ID: <4B98139B.6080202@vmware.com> (raw)
In-Reply-To: <201003102129.58617.pedro@codesourcery.com>
Pedro Alves wrote:
> On Wednesday 10 March 2010 21:24:57, Michael Snyder wrote:
>> This is not really my most familiar bit of the code, so
>> you gdbserver guys check me, ok?
>>
>> It seems to me that we need to set errno to zero before calling waitpid,
>> if we're going to check it right after. Especially the second time.
>
> I don't think do; we only check it if waitpid returns -1, and
> in that case, waitpid should have changed errno itself. Or
> have you found an actual problem here?
>
No, I guess you're right -- it just looked suspicious to me.
prev parent reply other threads:[~2010-03-10 21:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 21:25 Michael Snyder
2010-03-10 21:30 ` Pedro Alves
2010-03-10 21:48 ` Michael Snyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B98139B.6080202@vmware.com \
--to=msnyder@vmware.com \
--cc=dan@codesourcery.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox