From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70507-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9051 invoked by alias); 27 Feb 2010 01:04:24 -0000
Received: (qmail 8913 invoked by uid 22791); 27 Feb 2010 01:04:23 -0000
X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 	tests=BAYES_00
X-Spam-Check-By: sourceware.org
Received: from smtpauth19.prod.mesa1.secureserver.net (HELO smtpauth19.prod.mesa1.secureserver.net) (64.202.165.30)     by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Sat, 27 Feb 2010 01:04:18 +0000
Received: (qmail 17740 invoked from network); 27 Feb 2010 01:04:17 -0000
Received: from unknown (99.226.65.232)   by smtpauth19.prod.mesa1.secureserver.net (64.202.165.30) with ESMTP; 27 Feb 2010 01:04:17 -0000
Message-ID: <4B886F8C.1070002@moxielogic.com>
Date: Sat, 27 Feb 2010 01:04:00 -0000
From: Anthony Green <green@moxielogic.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.8) Gecko/20100216 Thunderbird/3.0.2
MIME-Version: 1.0
To: Jan Kratochvil <jan.kratochvil@redhat.com>
CC: gdb-patches@sourceware.org
Subject: Re: [patch] [sim/moxie] Fix NULL dereferences
References: <20100226124738.GA6773@host0.dyn.jankratochvil.net>
In-Reply-To: <20100226124738.GA6773@host0.dyn.jankratochvil.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-02/txt/msg00666.txt.bz2

On 2/26/2010 7:47 AM, Jan Kratochvil wrote:
> Hi,
>
> it looks as obvious to me but I know nothina about either sim or moxie.
>    

Thanks, please apply this if you haven't already.

AG


>
> Thanks,
> Jan
>
>
> This GDB was configured as "--host=x86_64-unknown-linux-gnu --target=moxie-unknown-elf".
> ./gdb -nx -ex 'target sim' -ex r
> = crash
>
> 2010-02-26  Jan Kratochvil<jan.kratochvil@redhat.com>
>
> 	* interp.c (sim_create_inferior): Fix crashes on zero PROG_BFD or ARGV.
>
> --- a/sim/moxie/interp.c
> +++ b/sim/moxie/interp.c
> @@ -1307,11 +1307,12 @@ sim_create_inferior (sd, prog_bfd, argv, env)
>     set_initial_gprs ();
>     issue_messages = l;
>
> -  cpu.asregs.regs[PC_REGNO] = bfd_get_start_address (prog_bfd);
> +  if (prog_bfd != NULL)
> +    cpu.asregs.regs[PC_REGNO] = bfd_get_start_address (prog_bfd);
>
>     /* Copy args into target memory.  */
>     avp = argv;
> -  for (argc = 0; *avp; avp++)
> +  for (argc = 0; avp&&  *avp; avp++)
>       argc++;
>
>     /* Target memory looks like this:
>