From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22094 invoked by alias); 12 Feb 2010 21:39:41 -0000 Received: (qmail 22084 invoked by uid 22791); 12 Feb 2010 21:39:41 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 12 Feb 2010 21:39:37 +0000 Received: from jupiter.vmware.com (mailhost5.vmware.com [10.16.68.131]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 32E0D32065; Fri, 12 Feb 2010 13:39:36 -0800 (PST) Received: from [10.20.124.101] (promd-2s-dhcp101.eng.vmware.com [10.20.124.101]) by jupiter.vmware.com (Postfix) with ESMTP id 1BA9EDC6D8; Fri, 12 Feb 2010 13:39:35 -0800 (PST) Message-ID: <4B75CA94.8010302@vmware.com> Date: Fri, 12 Feb 2010 21:39:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.22 (X11/20090609) MIME-Version: 1.0 To: Vladimir Prus CC: "gdb-patches@sources.redhat.com" Subject: Re: GDB MI Reverse Commands added [3 of 3] References: <00d001ca265a$ddd0c800$99725800$@com> <4B27E619.8080607@vmware.com> <200912161106.12861.vladimir@codesourcery.com> <010001ca7e2c$7ce406e0$76ac14a0$@com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00329.txt.bz2 Vladimir Prus wrote: > Jakob Engblom wrote: > >>> It does not seem like any of them were addressed. When they are addressed, >>> this patch is OK. Because the only non-mechanical change is replacement of >>> FIXME with a suitable comment, and reverse-mode experts are in much better >>> position to decide if a comment captures the behaviour properly, I don't >>> think I have to re-review any revision of this patch -- please commit directly >>> when you think it's ready. >> I think they are. The latest file that Michael Snyder attached: >> >> * Is called "mi-reverse.exp" > > Per Michael's last message, it seems that he just attached wrong file > when pinging, and this issue is now resolved. Committed.