Herewith, if anyone is interested, is what I expect is the final version of this patch, incorporating Joel's comments. Absent any objections, I expect I'll commit it Monday (just to give people time to object :-) ). [Joel, thanks for the link to the GDBTestcaseCookbook--extracting coherence from lots of oral tradition and examples dating from the mists of the distant past wasn't working well.] On 02/11/10 23:11, Joel Brobecker wrote: >> If you disagree strongly, then we could just close the PR and drop it, I >> suppose. I am not very intent on this, I just thought it would be a >> nice, if minor, enhancement. I didn't see a real downside. >> > > Not at all, I cannot say I like the idea, but if it's useful to others, > this is all that really matters. Let's go ahead, then. > > Regarding GNU indent - I know. But I try to keep formatting the code > the way GNU indent would do it in sane situations, as it helps keeping > some uniformity to our code. There are some rules I don't like (ahem, > ask me about spaces and tabs), but I think that uniformity is more > important... > > I'm happy I contributed just a little bit towards this patch - I really > felt bad reacting to it so so late in the game. > >