From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1939 invoked by alias); 8 Feb 2010 22:47:16 -0000 Received: (qmail 1930 invoked by uid 22791); 8 Feb 2010 22:47:15 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Feb 2010 22:47:11 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o18Ml1Xx021397 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 8 Feb 2010 17:47:01 -0500 Received: from qcore.mollernet.net (vpn-248-21.phx2.redhat.com [10.3.248.21]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o18Ml0xh021241; Mon, 8 Feb 2010 17:47:00 -0500 Message-ID: <4B709464.8010601@redhat.com> Date: Mon, 08 Feb 2010 22:47:00 -0000 From: Chris Moller User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2 MIME-Version: 1.0 To: Pedro Alves CC: gdb-patches@sourceware.org, tromey@redhat.com Subject: Re: PR11067 patch References: <4B6D70A3.2090208@redhat.com> <201002082232.39279.pedro@codesourcery.com> In-Reply-To: <201002082232.39279.pedro@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00237.txt.bz2 On 02/08/10 17:32, Pedro Alves wrote: > On Monday 08 February 2010 21:54:22, Tom Tromey wrote: > >>>>>>> "Chris" == Chris Moller writes: >>>>>>> >> Chris> The attached patch fixes bug 11067 "p should print the >> Chris> constant's value" by providing a means of setting a format string to >> Chris> be used in printing enums. The string is set with >> >> Chris> set enum-fmt >> >> I would rather not introduce a new option for this, particularly a >> formatting option. We don't have this sort of thing elsewhere in gdb -- >> we just pick a printing format or two. >> > > Ditto. > > >> I re-read the thread on the archer list. I propose having it print >> like: >> >> $2 = ENUMERATOR = (enum tag) 23 >> >> However, i would suppress the extra stuff in structs and when printing >> in summary mode. >> > > I seriously don't want to start a bikeshed, but, > IMO, I don't think it's a good idea to to invent new > output syntax for this. There's no need to print the type of > the enum, that's what ptype is for. And we don't do it for any > other type. > > We can look at enum's as having both a numeric facet, and > a symbolic facet, just like "char"s, and those we print as > > (gdb) p 'a' > $1 = 97 'a' > > If I had a choice, I would make printing enums exactly like: > > $2 = 23 'ENUMERATOR' > > This is short, concise, and models existing output. It > should look obvious what that output means. > > And then users don't have to learn to recognize/identify > different outputs depending on where the type is > embedded or printed. That sounds important usability > wise to me. > > Has this option seriously been discarded? > > As I said a few days ago, no matter what format I use, someone won't like it. I also asked The World to send me their objections /then/ rather than wait until I'd spent a couple of weekend nights coding the patch.