From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21266 invoked by alias); 8 Feb 2010 22:08:34 -0000 Received: (qmail 21257 invoked by uid 22791); 8 Feb 2010 22:08:33 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Feb 2010 22:08:28 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o18M8QIB017305 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 8 Feb 2010 17:08:26 -0500 Received: from qcore.mollernet.net (vpn-248-21.phx2.redhat.com [10.3.248.21]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o18M8P3b032573; Mon, 8 Feb 2010 17:08:26 -0500 Message-ID: <4B708B59.2030701@redhat.com> Date: Mon, 08 Feb 2010 22:08:00 -0000 From: Chris Moller User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2 MIME-Version: 1.0 To: tromey@redhat.com CC: gdb-patches@sourceware.org Subject: Re: PR11067 patch References: <4B6D70A3.2090208@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00234.txt.bz2 On 02/08/10 16:54, Tom Tromey wrote: >>>>>> "Chris" == Chris Moller writes: >>>>>> > > Chris> The attached patch fixes bug 11067 "p should print the > Chris> constant's value" by providing a means of setting a format string to > Chris> be used in printing enums. The string is set with > > Chris> set enum-fmt > > I would rather not introduce a new option for this, particularly a > formatting option. We don't have this sort of thing elsewhere in gdb -- > we just pick a printing format or two. > > I re-read the thread on the archer list. I propose having it print > like: > > $2 = ENUMERATOR = (enum tag) 23 > > However, i would suppress the extra stuff in structs and when printing > in summary mode. > Okay. I'll have to figure out how to determine if I'm in structs (or, I suppose, unions, arrays, and any other high-data-volume circumstance that might occur. cm > Tom >