From: Chris Moller <cmoller@redhat.com>
To: tromey@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: Patch for PR 10728
Date: Thu, 28 Jan 2010 18:38:00 -0000 [thread overview]
Message-ID: <4B61D9AF.3050002@redhat.com> (raw)
In-Reply-To: <m3zl3y9k47.fsf@fleche.redhat.com>
On 01/28/10 13:09, Tom Tromey wrote:
>>>>>> "Chris" == Chris Moller<cmoller@redhat.com> writes:
>>>>>>
>
>
> Chris> + untested psmang.exp
>
> Wrong name here, this occurs a few times.
>
Oops--the down side of cut'n'paste...
> Chris> +send_gdb "print x->y2 - x->y1\n"
> Chris> +
> Chris> +gdb_expect {
>
> I think we are trying to avoid send_gdb+gdb_expect, as much as possible.
> This test can comfortably be written using gdb_test, so do that.
>
I tried gdb_test to start with, but it didn't seem to be doing the right
thing. I just went back to it and it's doing okay now--my original
regex was probably screwed up.
Do you want me to send you a new patch? Or just commit it?
> Tom
>
next prev parent reply other threads:[~2010-01-28 18:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 19:41 Chris Moller
2010-01-28 18:09 ` Tom Tromey
2010-01-28 18:38 ` Chris Moller [this message]
2010-01-28 20:03 ` Tom Tromey
2010-02-03 20:41 ` Chris Moller
2010-02-03 20:50 ` Tom Tromey
2010-02-02 21:57 Chris Moller
2010-02-02 23:57 ` Tom Tromey
2010-02-03 4:36 ` Chris Moller
2010-02-03 18:23 ` Tom Tromey
2010-02-03 4:52 ` Chris Moller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B61D9AF.3050002@redhat.com \
--to=cmoller@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox