Re: [patch] Test cases nsusing.exp and nsrecurs.exp

Tom Tromey
2010-01-27T23:02:06Z

>>>>> "Sami" == Sami Wagiaalla <swagiaal@redhat.com> writes:

Sami> This patch contains the remainder of the nsusing.exp and nsrecurs.exp
Sami> test cases. Committing entire test cases makes it easier to manage
Sami> patches and avoids creation of unneeded conflicts. I have patches for
Sami> all the kfails.

I think it is more usual to submit the patches as a series, with the
test cases being one part, or to split them up. I don't really have a
problem with it this time, since I know you'll be sending them soon, but
next time this would be better.

What I do is make a private branch in git and make each commit a
separate submittable patch; then I rebase and/or edit the history as
needed.

Sami> +gdb_test "print _a" "No symbol \"_a\" in current context." "Print _a without import"

There are a few over-long lines like this. Break them up like:

gdb_test "print _a" "No symbol \"_a\" in current context." \
"Print _a without import"

Ok with that change.

Tom