From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-69299-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26067 invoked by alias); 6 Jan 2010 19:56:43 -0000
Received: (qmail 26058 invoked by uid 22791); 6 Jan 2010 19:56:42 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Jan 2010 19:56:39 +0000
Received: (qmail 28424 invoked from network); 6 Jan 2010 19:56:37 -0000
Received: from unknown (HELO macbook-2.local) (stan@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 6 Jan 2010 19:56:37 -0000
Message-ID: <4B44EAEF.9040206@codesourcery.com>
Date: Wed, 06 Jan 2010 19:56:00 -0000
From: Stan Shebs <stan@codesourcery.com>
User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
MIME-Version: 1.0
To: tromey@redhat.com
CC: Stan Shebs <stan@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Disconnected tracing
References: <4B441D89.6030902@codesourcery.com> <m34omz3tlu.fsf@fleche.redhat.com>
In-Reply-To: <m34omz3tlu.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-01/txt/msg00123.txt.bz2

Tom Tromey wrote:
>>>>>> "Stan" == Stan Shebs <stan@codesourcery.com> writes:
>>>>>>             
>
> Stan> This next patch realizes a long-anticipated advantage of tracepoints,
> Stan> namely that it should be possible to disconnect GDB from the target
> Stan> but leave the trace experiment running, then reconnect later to see if
> Stan> anything interesting turned up.
>
> A couple little nits...
>
> Stan> + extern void create_tracepoint_from_upload (int num, enum bptype type,
> Stan> + 					   ULONGEST addr);
>
> Could this be in a header?  And then the declaration in
> remote_get_tracing_state removed?
>
> Maybe this is another of those "will be fixed by the target vector"
> oddities.
>
>   
Yep, this is all going to get churned around by both target vector 
changes and uploading rewrite.  With unified syntax, the uploading part 
(qTfP/qTsP) is part of remote protocol, but the parsing of tracepoint 
info fields gets to be generic.

Stan