Re: gdb-patch mailing list

Joel Brobecker
2010-01-02T09:33:45Z

[I removed gdb-patches by accident - resending]

> >>>- Add new tracepoint action teval.
> >>>- * tracepoint.c (teval_pseudocommand): New function.
> >>>- (validate_actionline): Add teval action case.
> >>>- (encode_actions): Ditto.
> >>>- (_initialize_tracepoint): Define teval pseudocommand.
> >>>- * NEWS: Mention teval.
> >>[...]
> >>
> >>The leading minus '-' signs mean that you propose to remove this entry
> >>(and many other entries). I don't think you really meant that.
> this is not mine, I think you are in error??

This is exactly what I am saying: The patch you sent, if applied,
would cause all these entries in the ChangeLog file to be removed
(once approved, we apply use "patch" to apply the patch automatically,
we do not re-do the changes manually).

We both agree that this is not intentional. This is why you have
to double-check the contents of your patch before you send it,
to make sure that it contains all the changes that are you are
proposing to make, but also *only* the changes that you are proposing
to make.

It will probably simplify your life to just start over. Checkout
the sources from scratch, make your changes manually, and then
extract the diff. If you used CVS, then:
% cvs diff -up FILE1 FILE2 FILE3 [etc...] > patch.diff
If you used git:
% git diff > patch.diff

But regardless, always make sure to double-check your patch before
sending it. You may have slipped some unintentional changes by
accident, you never know.

--
Joel