Joel, Here it is again. For your information, I added a few lines of code to the 'info float' statement. Hope you like them :) Happy new year, Michael Joel Brobecker wrote: >> i accidentally reversed the source and destination source files, >> here it is again. >> > > Ah, ok! :). > > I am sorry if I am repeating the same things, but you forgot to use > -up when generating the patch... Have you also had the chance to > read the CONTRIBUTE file? The ChangeLog entry is still missing too. > A little word of introduction to explain what you are trying to do > and why would have been helpful as well. > > >> < /* Print the status word STATUS. */ >> < >> < static void >> < print_i387_status_word (unsigned int status, struct ui_file *file) >> --- >> >>> // print the status word >>> // updated 20091231 (development@codenamezero.org) >>> > > We do not use C++-style comments in the GDB code, because GDB is > supposed to be buildable with non-GCC compilers supporting ISO C90. > Also, the the "updated 20091231 (development@codenamezero.org)" is > superfluous and should go. > > >> < fprintf_filtered (file, "Status Word: %s", >> < hex_string_custom (status, 4)); >> < fputs_filtered (" ", file); >> < fprintf_filtered (file, " %s", (status & 0x0001) ? "IE" : " "); >> > > It looks like you changed the indentation of the code. This is not > correct. The indentation used in C for GNU projects is 2 spaces. > > The change of indentation causes a lot of changes which are not > really changes, and prevents me from easily spot what the real > changes are - if there are any, I couldn't spot them. > >