From: Michael Snyder <msnyder@vmware.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [ob] fix buf size in amd64_epilogue_frame_cache
Date: Sun, 20 Dec 2009 19:11:00 -0000 [thread overview]
Message-ID: <4B2E762E.7060302@vmware.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 116 bytes --]
Going to treat this one as obvious. Wrong buf size can cause
overflow and crash under inauspicious circumstances.
[-- Attachment #2: buf.txt --]
[-- Type: text/plain, Size: 695 bytes --]
2009-12-20 Michael Snyder <msnyder@vmware.com>
* amd64-tdep.c (amd64_epilogue_frame_cache): Fix buf size.
Index: amd64-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/amd64-tdep.c,v
retrieving revision 1.66
diff -u -p -r1.66 amd64-tdep.c
--- amd64-tdep.c 5 Nov 2009 21:17:00 -0000 1.66
+++ amd64-tdep.c 20 Dec 2009 19:08:58 -0000
@@ -1928,7 +1928,7 @@ amd64_epilogue_frame_cache (struct frame
struct gdbarch *gdbarch = get_frame_arch (this_frame);
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
struct amd64_frame_cache *cache;
- gdb_byte buf[4];
+ gdb_byte buf[8];
if (*this_cache)
return *this_cache;
next reply other threads:[~2009-12-20 19:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-20 19:11 Michael Snyder [this message]
2009-12-21 4:38 ` Joel Brobecker
2009-12-24 18:51 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2E762E.7060302@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox