From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27775 invoked by alias); 3 Dec 2009 16:06:26 -0000 Received: (qmail 27712 invoked by uid 22791); 3 Dec 2009 16:06:25 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Dec 2009 16:06:18 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nB3G6E3B025937 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 3 Dec 2009 11:06:14 -0500 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nB3G6Cfi002424; Thu, 3 Dec 2009 11:06:13 -0500 Message-ID: <4B17E1F4.1000203@redhat.com> Date: Thu, 03 Dec 2009 16:06:00 -0000 From: Phil Muldoon User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Lightning/1.0pre Thunderbird/3.0b4 MIME-Version: 1.0 To: Eli Zaretskii CC: tromey@redhat.com, gdb-patches@sourceware.org Subject: Re: [python][patch] Add is_base_class attribute to fields. References: <4B13A147.2040208@redhat.com> <4B17D4C3.1040703@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00029.txt.bz2 On 12/03/2009 03:39 PM, Eli Zaretskii wrote: >> Date: Thu, 03 Dec 2009 15:09:55 +0000 >> From: Phil Muldoon >> CC: gdb-patches ml >> >> I've modified the patch as attached. If Eli does not have any comments or >> changes to the doc section, this is what I will commit. > > The doco part is okay, except for one issue: > >> +structure. This attribute is always provided, and is @code{False} >> +if the field is not a base class of the type on which @code{fields} was > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> +called, or if that type was not a C@t{++} class. > ^^^^^^ > I think ``the type that is the argument of @code{fields}'' is much > more clear (unless I misunderstood what you wanted to say). That's ok with me. I'll adjust and commit. Cheers, Phil