Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [RFA/RFC] Prec multi-thread support [3/4] thread.c
Date: Wed, 25 Nov 2009 20:10:00 -0000	[thread overview]
Message-ID: <4B0D8E26.9050701@vmware.com> (raw)
In-Reply-To: <daef60380911250006v5d58ff18g9677731e91805fb8@mail.gmail.com>

This one's OK.  In fact, congratulations for keeping this part
of your change so neat and concise!   ;-)

Hui Zhu wrote:
> 1. Move thread_state to gdbthread.h because record target need get the
> status of each thread.  Sometime, GDB will not remove the thread entry
> when it exit.
> 2. record_is_waiting is to flag that mean this thread is still
> running.  I will introduce in next mail.
> 
> 2009-11-25  Hui Zhu  <teawater@gmail.com>
> 
> 	gdbthread.h (thread_state): New enum.
> 	(thread_info): Add record_is_waiting.
> 	thread.c (thread_state): Deleted.
> 
> ---
>  gdbthread.h |   11 +++++++++++
>  thread.c    |    9 ---------
>  2 files changed, 11 insertions(+), 9 deletions(-)
> 
> --- a/gdbthread.h
> +++ b/gdbthread.h
> @@ -29,6 +29,15 @@ struct symtab;
>  #include "ui-out.h"
>  #include "inferior.h"
> 
> +/* Frontend view of the thread state.  Possible extensions: stepping,
> +   finishing, until(ling),...  */
> +enum thread_state
> +{
> +  THREAD_STOPPED,
> +  THREAD_RUNNING,
> +  THREAD_EXITED,
> +};
> +
>  struct thread_info
>  {
>    struct thread_info *next;
> @@ -37,6 +46,8 @@ struct thread_info
>  				    kernel thread id, etc.  */
>    int num;			/* Convenient handle (GDB thread id) */
> 
> +  int record_is_waiting;
> +
>    /* Non-zero means the thread is executing.  Note: this is different
>       from saying that there is an active target and we are stopped at
>       a breakpoint, for instance.  This is a real indicator whether the
> --- a/thread.c
> +++ b/thread.c
> @@ -63,15 +63,6 @@ static void thread_apply_command (char *
>  static void restore_current_thread (ptid_t);
>  static void prune_threads (void);
> 
> -/* Frontend view of the thread state.  Possible extensions: stepping,
> -   finishing, until(ling),...  */
> -enum thread_state
> -{
> -  THREAD_STOPPED,
> -  THREAD_RUNNING,
> -  THREAD_EXITED,
> -};
> -
>  struct thread_info*
>  inferior_thread (void)
>  {


  reply	other threads:[~2009-11-25 20:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-25  8:06 Hui Zhu
2009-11-25 20:10 ` Michael Snyder [this message]
2009-11-26  6:46   ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B0D8E26.9050701@vmware.com \
    --to=msnyder@vmware.com \
    --cc=gdb-patches@sourceware.org \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox