From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30608 invoked by alias); 11 Nov 2009 19:27:23 -0000 Received: (qmail 30594 invoked by uid 22791); 11 Nov 2009 19:27:23 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Nov 2009 19:27:18 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 7A13913A99 for ; Wed, 11 Nov 2009 11:27:17 -0800 (PST) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost4.vmware.com (Postfix) with ESMTP id 6CDC1C9A1B; Wed, 11 Nov 2009 11:27:17 -0800 (PST) Message-ID: <4AFB0FB9.40105@vmware.com> Date: Wed, 11 Nov 2009 19:27:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20090624) MIME-Version: 1.0 To: Michael Snyder , "gdb-patches@sourceware.org" Subject: Re: [RFA] comment looks wrong... References: <4AE89A1F.2080502@vmware.com> <20091028200435.GA13464@caradoc.them.org> <4AEDD14C.4080505@vmware.com> <20091101193312.GA31647@caradoc.them.org> <4AEDF1AE.9040402@vmware.com> <20091102005657.GA29533@caradoc.them.org> In-Reply-To: <20091102005657.GA29533@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00260.txt.bz2 Daniel Jacobowitz wrote: > On Sun, Nov 01, 2009 at 12:38:06PM -0800, Michael Snyder wrote: >> +/* Basic byte-swapping routines. GDB has needed these for a long >> + time... All 'extract' functions return a host-format integer >> + from a target-format integer ADDR which is LEN bytes long. */ > > I suggest dropping the long time comment, and putting back the lost > "at": > > /* Basic byte-swapping routines. All 'extract' functions return a > host-format integer from a target-format integer at ADDR which > is LEN bytes long. */ > > > How's that? Agreed and committed. Thanks.