Tom Tromey wrote:
>>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
> 
> Michael> How about this?
> 
> Michael> +struct bookmark *bookmark_chain;
> Michael> +int bookmark_count;
> 
> These should be static.

OK.

> Michael> +static int
> Michael> +delete_one_bookmark (struct bookmark *b)
> Michael> +{
> [...]
> Michael> +  /* Find bookmark preceeding "marked" one, so we can unlink.  */
> Michael> +  /* FIXME what about end cases (first and last)?  */
> 
> We're trying to avoid new FIXMEs.

Sorry, left over, removed.

> I think instead of using ALL_BOOKMARKS this code would be simpler and
> more obviously correct if it just had an explicit loop.  There's no need
> to have a special case for the first element of the list, either.  E.g.,
> see the deletion code in cli-decode.c:delete_cmd.

Well, my model was breakpoints.  Do you really insist that I change it?