From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27511 invoked by alias); 9 Nov 2009 20:37:51 -0000 Received: (qmail 27503 invoked by uid 22791); 9 Nov 2009 20:37:51 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Nov 2009 20:37:46 +0000 Received: (qmail 27734 invoked from network); 9 Nov 2009 20:37:44 -0000 Received: from unknown (HELO ?192.168.9.129?) (daniel@127.0.0.2) by mail.codesourcery.com with ESMTPA; 9 Nov 2009 20:37:44 -0000 Message-ID: <4AF87D90.8070907@codesourcery.com> Date: Mon, 09 Nov 2009 20:37:00 -0000 From: Daniel Gutson User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Daniel Jacobowitz , Michael Snyder , "gdb-patches@sourceware.org" Subject: Re: [PATCH] gcore registers storing fix References: <4AF4A505.4010600@codesourcery.com> <4AF72404.1070808@vmware.com> <4AF82E4E.8000500@codesourcery.com> <20091109153110.GA12924@caradoc.them.org> <4AF85CC0.2030002@codesourcery.com> <20091109182550.GA30593@caradoc.them.org> <4AF86112.2040304@codesourcery.com> <20091109201028.GA8855@caradoc.them.org> <4AF87C4C.8010504@codesourcery.com> <20091109203352.GA11579@caradoc.them.org> In-Reply-To: <20091109203352.GA11579@caradoc.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00166.txt.bz2 Daniel Jacobowitz wrote: > On Mon, Nov 09, 2009 at 05:32:12PM -0300, Daniel Gutson wrote: >> >> Daniel Jacobowitz wrote: >>> On Mon, Nov 09, 2009 at 03:36:02PM -0300, Daniel Gutson wrote: >>>> Because none of them checks that the text "in ??" does *not* show up >>> Michael has pointed out that this text can legitimately appear. >>> If there is a function in the system libraries without debug >>> information, we may be there. For instance, inside the implementation >>> of printf. >> OK, should I just remove the test case then? That, or only check that >> the ?? is not in the current thread. > > Let's drop the new test. The code part of your patch is OK to commit. OK, thanks. Please note that I don't have write access, please commit it for me if ever possible. -- Daniel Gutson CodeSourcery www.codesourcery.com