From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20410 invoked by alias); 9 Nov 2009 12:06:47 -0000 Received: (qmail 20401 invoked by uid 22791); 9 Nov 2009 12:06:46 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Nov 2009 12:06:40 +0000 Received: (qmail 23926 invoked from network); 9 Nov 2009 12:06:38 -0000 Received: from unknown (HELO ?192.168.44.101?) (nathan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 9 Nov 2009 12:06:38 -0000 Message-ID: <4AF805C8.7060009@codesourcery.com> Date: Mon, 09 Nov 2009 12:06:00 -0000 From: Nathan Sidwell User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [testsuite] check for languages consistently References: <4AF058B6.2070808@codesourcery.com> <20091107022153.GM4557@adacore.com> In-Reply-To: <20091107022153.GM4557@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00132.txt.bz2 Joel Brobecker wrote: >> 2009-11-03 Nathan Sidwell >> >> * lib/gdb.exp (gdb_compile_test): New. >> (skip_ada_tests, skip_java_tests): New. >> (gdb_compile): Use gdb_compile_test for f77. >> * lib/ada.exp (gdb_compile_ada): Use gdb_compile_test to record result. >> * lib/java.exp (compile_java_from_source): Remove runtests check, >> use gdb_compile_test to record result. >> * gdb.ada/packed_array.exp, gdb.ada/fixed_points.exp, >> gdb.ada/exec_changed.exp, gdb.ada/start.exp, >> gdb.ada/watch_arg.exp, gdb.ada/null_record.exp, >> gdb.ada/array_return.exp, gdb.ada/arrayidx.exp, >> gdb.mi/mi-var-child-f.exp, gdb.fortran/types.exp, >> gdb.fortran/array-element.exp, gdb.fortran/subarray.exp, >> gdb.fortran/derived-type.exp, gdb.fortran/exprs.exp, >> gdb.java/jmisc.exp, gdb.java/jmisc1.exp, gdb.java/jprint.exp, >> gdb.java/jv-print.exp, gdb.java/jmain.exp: Add language skip, >> adjust gdb_compile invocations. > > Looks OK to me, except for one question. Did you test this with a java > compiler around, by any chance? This is the only part that I'm not sure > about. I just don't understand exactly what the bits you are removing > are trying to do (I'm reading the dejagnu documentation and it's not > quite helping...). this time round I didn't have a java compiler available. I'm pretty certain I checked with/without before. nathan -- Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery