From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10399 invoked by alias); 4 Nov 2009 08:26:54 -0000 Received: (qmail 10390 invoked by uid 22791); 4 Nov 2009 08:26:53 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 04 Nov 2009 08:26:49 +0000 Received: (qmail 8994 invoked from network); 4 Nov 2009 08:26:47 -0000 Received: from unknown (HELO ?172.16.1.24?) (maxim@127.0.0.2) by mail.codesourcery.com with ESMTPA; 4 Nov 2009 08:26:47 -0000 Message-ID: <4AF13ABF.7030407@codesourcery.com> Date: Wed, 04 Nov 2009 08:26:00 -0000 From: Maxim Kuvyrkov User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) MIME-Version: 1.0 To: Maxim Kuvyrkov , gdb-patches@sourceware.org, Andreas Schwab Subject: Re: [PATCH, M68K] Handle TLS References: <4AF05659.1070404@codesourcery.com> <20091103230812.GA8761@caradoc.them.org> In-Reply-To: <20091103230812.GA8761@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00077.txt.bz2 Daniel Jacobowitz wrote: > On Tue, Nov 03, 2009 at 07:12:09PM +0300, Maxim Kuvyrkov wrote: >> Hi, >> >> The following simple patch adds handling of TLS to m68k gdbserver. >> >> A corresponding kernel patch is being reviewed here >> . >> >> Tested on coldfire-linux. >> >> OK to apply? > > This is fine with two caveats: > > * I think it would be best to not apply it until you have an ack for > the kernel patch defining PTRACE_GET_THREAD_AREA. OK, that may take a while though. > > * Provide a fallback definition for PTRACE_GET_THREAD_AREA. I assume > existing m68k kernel headers do not define it, so the build would > fail. OK. Thanks for the review! -- Maxim Kuvyrkov CodeSourcery maxim@codesourcery.com (650) 331-3385 x724