From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24277 invoked by alias); 3 Nov 2009 18:42:52 -0000 Received: (qmail 24264 invoked by uid 22791); 3 Nov 2009 18:42:51 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 Nov 2009 18:42:46 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id E940C13632; Tue, 3 Nov 2009 10:42:42 -0800 (PST) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost4.vmware.com (Postfix) with ESMTP id DB451C9B4A; Tue, 3 Nov 2009 10:42:42 -0800 (PST) Message-ID: <4AF0799E.4020705@vmware.com> Date: Tue, 03 Nov 2009 18:42:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20090624) MIME-Version: 1.0 To: Jakob Engblom CC: 'Eli Zaretskii' , "gdb-patches@sourceware.org" , "glaw@undo-software.com" , "teawater@gmail.com" Subject: Re: [RFA] replay bookmarks References: <4AEDF9F4.9040207@vmware.com> <834opec530.fsf@gnu.org> <4AEE27E9.1070005@vmware.com> <831vkhd18a.fsf@gnu.org> <001101ca5c60$7220f9e0$5662eda0$@com> In-Reply-To: <001101ca5c60$7220f9e0$5662eda0$@com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00064.txt.bz2 Jakob Engblom wrote: >>>>> Date: Sun, 01 Nov 2009 13:13:24 -0800 >>>>> From: Michael Snyder >>>>> >>>>> + add_com ("bookmark", class_bookmark, save_bookmark_command, _("\ >>>>> +Set a bookmark.\n\ >>>> This is way too short. Suggest to expand a bit: >>>> >>>> Set a bookmark in the inferior's execution history >>>> >>>>> + add_com ("goto-bookmark", class_bookmark, goto_bookmark_command, _("\ >>>>> +Go to bookmark \n\ >>>> Similarly here: such a short description is hardly useful, as it just >>>> repeats the name of the command. >>> How about this? >> Fine with me. >> >> There are a few instances of user messages where the text is not >> marked by _(). >> >> Also, we will need an update for the manual, once this is approved. > > Also, will this add corresponding operations to gdb-serial? That is necessary to > get this working for undodb, Simics, and similar remote-exec bookmarkable > targets. I guess that also means VMWare, right? Right. But I haven't tested the remote serial bits, so any feedback that you have will be helpful. This is the implementation of the protocol question that I asked you earlier.