[RFA] comment looks wrong...

Michael Snyder
2009-10-28T19:31:06Z

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

The comment in findvar about extract_*_integer looked wrong to me,
with respect to target vs. host. If I'm right, this is an improvement,
but if I'm confused, then so are these comments. ;-/

[-- Attachment #2: findvar.txt --]
[-- Type: text/plain, Size: 1166 bytes --]

2009-10-28 Michael Snyder <msnyder@vmware.com>

* findvar.c (top level): Fix and add comments.

Index: findvar.c
===================================================================
RCS file: /cvs/src/src/gdb/findvar.c,v
retrieving revision 1.126
diff -u -p -r1.126 findvar.c
--- findvar.c 2 Jul 2009 17:25:53 -0000 1.126
+++ findvar.c 28 Oct 2009 19:28:48 -0000
@@ -36,8 +36,9 @@
#include "block.h"
#include "objfiles.h"

-/* Basic byte-swapping routines. GDB has needed these for a long time...
- All extract a target-format integer at ADDR which is LEN bytes long. */
+/* Basic byte-swapping routines. GDB has needed these for a long
+ time... All 'extract' functions extract a host-format integer at
+ ADDR which is LEN bytes long. */

#if TARGET_CHAR_BIT != 8 || HOST_CHAR_BIT != 8
/* 8 bit characters are a pretty safe assumption these days, so we
@@ -179,6 +180,8 @@ extract_typed_address (const gdb_byte *b
return gdbarch_pointer_to_address (get_type_arch (type), type, buf);
}

+/* All 'store' functions store a target-format integer at ADDR
+ which is LEN bytes long. */

void
store_signed_integer (gdb_byte *addr, int len,