From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27831 invoked by alias); 1 Nov 2009 20:37:55 -0000 Received: (qmail 27823 invoked by uid 22791); 1 Nov 2009 20:37:54 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 01 Nov 2009 20:37:50 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 7BBEDC04E for ; Sun, 1 Nov 2009 12:37:49 -0800 (PST) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost3.vmware.com (Postfix) with ESMTP id 71F1DCD98C; Sun, 1 Nov 2009 12:37:49 -0800 (PST) Message-ID: <4AEDF1AE.9040402@vmware.com> Date: Sun, 01 Nov 2009 20:37:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20090624) MIME-Version: 1.0 To: Michael Snyder , "gdb-patches@sourceware.org" Subject: Re: [RFA] comment looks wrong... References: <4AE89A1F.2080502@vmware.com> <20091028200435.GA13464@caradoc.them.org> <4AEDD14C.4080505@vmware.com> <20091101193312.GA31647@caradoc.them.org> In-Reply-To: <20091101193312.GA31647@caradoc.them.org> Content-Type: multipart/mixed; boundary="------------000408050207030904050202" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00006.txt.bz2 This is a multi-part message in MIME format. --------------000408050207030904050202 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 326 Daniel Jacobowitz wrote: > On Sun, Nov 01, 2009 at 10:19:56AM -0800, Michael Snyder wrote: >> Does that mean you don't favor changing it? > > Your new formulation uses the opposite meaning of extract to the one > presently there. If the old one was unclear, the new one is unclear > also... > Fair enough -- how's this? --------------000408050207030904050202 Content-Type: text/plain; name="findvar.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="findvar.txt" Content-length: 1126 2009-10-28 Michael Snyder * findvar.c (top level): Fix and add comments. Index: gdb/findvar.c =================================================================== --- gdb.orig/findvar.c 2009-10-28 12:33:28.000000000 -0700 +++ gdb/findvar.c 2009-11-01 12:37:26.000000000 -0800 @@ -36,8 +36,9 @@ #include "block.h" #include "objfiles.h" -/* Basic byte-swapping routines. GDB has needed these for a long time... - All extract a target-format integer at ADDR which is LEN bytes long. */ +/* Basic byte-swapping routines. GDB has needed these for a long + time... All 'extract' functions return a host-format integer + from a target-format integer ADDR which is LEN bytes long. */ #if TARGET_CHAR_BIT != 8 || HOST_CHAR_BIT != 8 /* 8 bit characters are a pretty safe assumption these days, so we @@ -179,6 +180,8 @@ return gdbarch_pointer_to_address (get_type_arch (type), type, buf); } +/* All 'store' functions accept a host-format integer and store a + target-format integer at ADDR which is LEN bytes long. */ void store_signed_integer (gdb_byte *addr, int len, --------------000408050207030904050202--