From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13022 invoked by alias); 1 Nov 2009 18:28:32 -0000 Received: (qmail 13014 invoked by uid 22791); 1 Nov 2009 18:28:31 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 01 Nov 2009 18:28:28 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id AE8A112167 for ; Sun, 1 Nov 2009 10:28:26 -0800 (PST) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost3.vmware.com (Postfix) with ESMTP id A2C3ECD9FC; Sun, 1 Nov 2009 10:28:26 -0800 (PST) Message-ID: <4AEDD14C.4080505@vmware.com> Date: Sun, 01 Nov 2009 18:28:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20090624) MIME-Version: 1.0 To: Michael Snyder , "gdb-patches@sourceware.org" Subject: Re: [RFA] comment looks wrong... References: <4AE89A1F.2080502@vmware.com> <20091028200435.GA13464@caradoc.them.org> In-Reply-To: <20091028200435.GA13464@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00002.txt.bz2 Daniel Jacobowitz wrote: > On Wed, Oct 28, 2009 at 12:23:11PM -0700, Michael Snyder wrote: >> The comment in findvar about extract_*_integer looked wrong to me, >> with respect to target vs. host. If I'm right, this is an improvement, >> but if I'm confused, then so are these comments. ;-/ > > It's some subject/object fuzziness, I think. > >> -/* Basic byte-swapping routines. GDB has needed these for a long time... >> - All extract a target-format integer at ADDR which is LEN bytes long. */ >> +/* Basic byte-swapping routines. GDB has needed these for a long >> + time... All 'extract' functions extract a host-format integer at >> + ADDR which is LEN bytes long. */ > > Which do you extract - the value being read or the value being > returned? It means the value being read, which is in target format. > Does that mean you don't favor changing it?