Re: [RFA] Makefile.in, linux.mh: Move Process Record to NATDEPFILES

Hui Zhu
2009-10-24T03:07:22Z

Sorry. I cannot agree with this patch. It make record to be the
linux-special code.

Thanks,
Hui

On Fri, Oct 23, 2009 at 23:44, Michael Snyder <msnyder@vmware.com> wrote:
> Hey folks, we ran into a bunch of build problems because record.c
> was being compiled in a lot of builds where it wasn't needed (or
> tested).
>
> This change will make record.c be like gcore.c, in that it is only
> built if the target config files explicitly call for it.
>
> For this patch, I've only included record.c for i386-linux.
> We can add amd64-linux in a separate patch if we decide it is
> ready.
>
> Michael
>
>
> 2009-10-23  Michael Snyder  <msnyder@vmware.com>
>
>        * Makefile.in (COMMON_OBS): Remove record.o.
>        (ALL_TARGET_OBS): Remove linux-record.o.
>        config/i386/linux.h (NATDEPFILES): Add record.o, linux-record.o.
>
> Index: Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/gdb/Makefile.in,v
> retrieving revision 1.1103
> diff -u -p -w -b -r1.1103 Makefile.in
> --- Makefile.in 21 Oct 2009 14:14:56 -0000      1.1103
> +++ Makefile.in 23 Oct 2009 15:45:31 -0000
> @@ -531,8 +531,7 @@ ALL_TARGET_OBS = \
>        xcoffread.o \
>        symfile-mem.o \
>        corelow.o \
> -       windows-tdep.o \
> -       linux-record.o
> +       windows-tdep.o
>
>  # Host-dependent makefile fragment comes in here.
>  @host_makefile_frag@
> @@ -834,7 +833,7 @@ COMMON_OBS = $(DEPFILES) $(CONFIG_OBS) $
>        solib.o solib-null.o \
>        prologue-value.o memory-map.o xml-support.o xml-syscall.o \
>        target-descriptions.o target-memory.o xml-tdesc.o xml-builtin.o \
> -       inferior.o osdata.o gdb_usleep.o record.o \
> +       inferior.o osdata.o gdb_usleep.o \
>        jit.o progspace.o
>
>  # Definitions for the syscall's XML files and dir
> Index: config/i386/linux.mh
> ===================================================================
> RCS file: /cvs/src/src/gdb/config/i386/linux.mh,v
> retrieving revision 1.21
> diff -u -p -w -b -r1.21 linux.mh
> --- config/i386/linux.mh        14 Aug 2007 12:51:59 -0000      1.21
> +++ config/i386/linux.mh        23 Oct 2009 15:45:31 -0000
> @@ -4,7 +4,7 @@ NAT_FILE= nm-linux.h
>  NATDEPFILES= inf-ptrace.o fork-child.o \
>        i386-nat.o i386-linux-nat.o \
>        proc-service.o linux-thread-db.o gcore.o \
> -       linux-nat.o linux-fork.o
> +       linux-nat.o linux-fork.o linux-record.o record.o
>
>  # The dynamically loaded libthread_db needs access to symbols in the
>  # gdb executable.
>
>