From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25489 invoked by alias); 22 Oct 2009 19:59:35 -0000 Received: (qmail 25481 invoked by uid 22791); 22 Oct 2009 19:59:35 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Oct 2009 19:59:31 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 5B4A8C02C; Thu, 22 Oct 2009 12:59:30 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost2.vmware.com (Postfix) with ESMTP id 3EEFC8E76D; Thu, 22 Oct 2009 12:59:30 -0700 (PDT) Message-ID: <4AE0B811.30604@vmware.com> Date: Thu, 22 Oct 2009 19:59:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Joel Brobecker CC: "gdb-patches@sourceware.org" , Hui Zhu Subject: Re: [RFA] New testes for process record save/restore commands References: <4ADCC1CE.1090304@vmware.com> <20091019200322.GD5282@adacore.com> In-Reply-To: <20091019200322.GD5282@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00539.txt.bz2 Joel Brobecker wrote: >> 2009-10-19 Michael Snyder >> >> * gdb.reverse/break-precsave.exp: New test. >> * gdb.reverse/consecutive-precsave.exp: Ditto. >> * gdb.reverse/finish-precsave.exp: Ditto. >> * gdb.reverse/i386-precsave.exp: Ditto. >> * gdb.reverse/machinestate-precsave.exp: Ditto. >> * gdb.reverse/sigall-precsave.exp: Ditto. >> * gdb.reverse/solilb-precsave.exp: Ditto. >> * gdb.reverse/step-precsave.exp: Ditto. >> * gdb.reverse/until-precsave.exp: Ditto. >> * gdb.reverse/watch-precsave.exp: Ditto. > > I only quickly scanned the files, since they are essentially duplicates > of already-existing testcases. I didn't expect to find anything, but > I actually did notice a couple of things: > > - Use of send_gdb/gdb_expect which should be replaced by gdb_test_multiple > (too bad we didn't catch those in the current ones when the testcases > were checked in) > - unnecessary "return 0" at the end of the script. > > I think we shouldn't put anything unnecessary in these files, as we tend > to forget why we put them, and the next developer who, like me, writes > testcase by copy/paste, will repeat the pattern because he's afraid of > breaking something otherwise. OK, committed with *some* of the gdb_expects removed. I'm not entirely sure how to remove some of them, and I've no objection to anyone else banging on them. ;-)