From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-67912-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18592 invoked by alias); 22 Oct 2009 19:42:59 -0000
Received: (qmail 18584 invoked by uid 22791); 22 Oct 2009 19:42:59 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Oct 2009 19:42:56 +0000
Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) 	by smtp-outbound-2.vmware.com (Postfix) with ESMTP id D0CDF43017; 	Thu, 22 Oct 2009 12:42:54 -0700 (PDT)
Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) 	by mailhost2.vmware.com (Postfix) with ESMTP id B1F8C8E8C4; 	Thu, 22 Oct 2009 12:42:54 -0700 (PDT)
Message-ID: <4AE0B42E.7030306@vmware.com>
Date: Thu, 22 Oct 2009 19:42:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 1.5.0.12 (X11/20080411)
MIME-Version: 1.0
To: Michael Snyder <msnyder@vmware.com>
CC: "tromey@redhat.com" <tromey@redhat.com>,   "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,  Hui Zhu <teawater@gmail.com>, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA, 5 of 3] save/restore process record, part 5 (gcore change)
References: <4ADA9558.2010202@vmware.com> <m34opv9x2v.fsf@fleche.redhat.com> <4ADCC6D2.9000406@vmware.com>
In-Reply-To: <4ADCC6D2.9000406@vmware.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-10/txt/msg00535.txt.bz2

Michael Snyder wrote:
> Tom Tromey wrote:
>>>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
>> Michael> +/* create_gcore_bfd -- helper for gcore_command (exported).  */
>>  
>> Michael> +bfd *
>> Michael> +create_gcore_bfd (char *filename)
>>
>> That comment is not very descriptive.
>>
>> Michael> +/* write_gcore_file -- helper for gcore_command (exported).  */
>> Michael> +
>> Michael> +void
>> Michael> +write_gcore_file (bfd *obfd)
>>
>> Likewise.
>>
>> Michael> Index: gcore.h
>> Michael> ===================================================================
>> Michael> RCS file: gcore.h
>> Michael> diff -N gcore.h
>>
>> The gdb internals document says that headers should have include guards.
> 
> OK.  Also, I found that I had included some code in this patch
> that I didn't need -- so this version is shorter.   ;-)
> 

And committed.