On 19/10/09 20:33, Joel Brobecker wrote:
> I just a few minor comments. This is pre-approved after the comments
> have been addressed.

OK, I've attached what I committed.

> Personally, I would prefer it if you declared the two functions
> sh_corefile_supply_regset and sh_corefile_collect_regset as non-static
> and using them directly, rather than accessing a global constant to call
> a function.  This made me believe, at first, that you were accessing
> a global variable that was set while the target was determined, and thus
> would not be multiarch-friendly.  I see now that this is not the case,
> so the code looks correct to me now. I would just delete the code
> and replace the calls form shnbsd-nat.c to the calls to the new
> sh_corefile_supply/collect_regset functions.

I have done this. This resulted in shnbsd-tdep.h having no contents, so 
I've deleted it.

Otherwise, the only changes are the ones you requested.

Andrew