Re: [patch][doc] PR python/10781

Eli Zaretskii
2009-10-16T07:46:43Z

> Date: Fri, 16 Oct 2009 08:35:35 +0100
> From: Phil Muldoon <pmuldoon@redhat.com>
>
> On irc, Michael Lyle noticed that Value.cast was not documented in GDB
> 7.0, but the method was available for use. Tom wrote this documentation
> sometime ago, and it got missed on the merge. This patch fixes this.
>
> OK?

I have a few comments:

> +Cast the @code{gdb.Value} to the type represented by @var{type}, and
^^^
Please remove this "the".

> +return a new @code{gdb.Value}. @var{type} must be a @code{gdb.Type}
> +object.

If TYPE is an object, then it probably isn't a good idea to call it
TYPE. Why not OBJECT?

Anyway, what does it mean "the type represented by TYPE"? How can a
type be "represented"? Did you perhaps mean "the type of TYPE"?

> If the cast cannot be performed for some reason, an exception
> +is thrown.

Suggest to rephrase to avoid passive tense.

Thanks.