From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14011 invoked by alias); 15 Oct 2009 17:12:43 -0000 Received: (qmail 13981 invoked by uid 22791); 15 Oct 2009 17:12:41 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from shell4.bayarea.net (HELO shell4.bayarea.net) (209.128.82.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Oct 2009 17:12:36 +0000 Received: (qmail 23201 invoked from network); 15 Oct 2009 10:12:34 -0700 Received: from 209-128-106-254.bayarea.net (HELO redwood.eagercon.com) (209.128.106.254) by shell4.bayarea.net with SMTP; 15 Oct 2009 10:12:31 -0700 Message-ID: <4AD757FE.6060704@eagercon.com> Date: Thu, 15 Oct 2009 17:12:00 -0000 From: Michael Eager User-Agent: Thunderbird 2.0.0.23 (X11/20090825) MIME-Version: 1.0 To: tromey@redhat.com CC: "gdb-patches@sourceware.org" , Joel Brobecker Subject: Re: [PATCH] Support for Xilinx MicroBlaze References: <4AD74E86.1020500@eagercon.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00341.txt.bz2 Tom Tromey wrote: >>>>>> "Michael" == Michael Eager writes: > > Michael> When (if) this is fixed in gcc there will need to coordinate > Michael> this with a corresponding fix in gdb. > > How would this be done? > Users might be using an old gcc or a new one. Not easy. It would require coordination with users. Lots. Perhaps a test to see if code was generated by a particular version of gcc or something equally ugly. Even if gcc was fixed to accept reg+8 for the return address, there would need to be a change to the MicroBlaze-specific INCOMING_RETURN_ADDR_RTX for it to take any effect. (There's a warning note about this in gcc, which I might make more emphatic.) So this is not going to happen by accident. I'm just as happy to leave this problem unfixed. Gcc generates an incorrect CIE entry, which is philosophically not a good thing. But fixing this causes far more problems than it solves. > Michael> diff -urNp --exclude '*.swp' --exclude DEV-PHASE --exclude .svn --exclude CVS gdb/gdb/NEWS mb-gdb/gdb/NEWS > Michael> --- gdb/gdb/NEWS 2009-10-14 11:15:51.000000000 -0700 > Michael> +++ mb-gdb/gdb/NEWS 2009-10-14 19:15:57.000000000 -0700 > Michael> @@ -484,6 +484,11 @@ Lattice Mico32 lm32-* > Michael> x86 DICOS i[34567]86-*-dicos* > Michael> x86_64 DICOS x86_64-*-dicos* > Michael> S+core 3 score-*-* > Michael> +Xilinx MicroBlaze microblaze-*-* > Michael> + > Michael> +* New Simulators > Michael> + > Michael> +Xilinx MicroBlaze microblaze > > I think this changes the "7.0" section, not the "since 7.0" section. Oops. The "Changes in GDB 7.0" was added after I updated the file and I didn't notice it. I'll move the entry. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077