From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23100 invoked by alias); 12 Oct 2009 15:43:30 -0000 Received: (qmail 23088 invoked by uid 22791); 12 Oct 2009 15:43:29 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Oct 2009 15:43:25 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id A4063130C4; Mon, 12 Oct 2009 08:43:24 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost2.vmware.com (Postfix) with ESMTP id 87C798E847; Mon, 12 Oct 2009 08:43:24 -0700 (PDT) Message-ID: <4AD34D7C.2030309@vmware.com> Date: Mon, 12 Oct 2009 15:43:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Jiang Jilin CC: Hui Zhu , gdb-patches ml Subject: Re: [PATCH] Add xgetbv/xsetbv instructions support for precord. References: <1255095434-30271-1-git-send-email-freephp@gmail.com> <4ACFB7AB.6030708@vmware.com> <7d77a27d0910120059x23aae91dv66baaf44ff74c15a@mail.gmail.com> In-Reply-To: <7d77a27d0910120059x23aae91dv66baaf44ff74c15a@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00234.txt.bz2 Jiang Jilin wrote: > Hi Michael, > > Is this small patch acceptable? If yes, please tell me who can help me > check it in, > you know, I've no write permission. Cool, I think Hui, Joel and I all approved this patch. I'll check it in -- consider it committed. > On Sat, Oct 10, 2009 at 6:22 AM, Michael Snyder wrote: >> Jiang Jilin wrote: >>> 2009-10-09 Jiang Jilin >>> >>> * i386-tdep.c (i386_process_record): Add xgetbv/xsetbv instructions >>> support >>> --- >>> gdb/i386-tdep.c | 13 +++++++++++++ >>> 1 files changed, 13 insertions(+), 0 deletions(-) >>> >>> diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c >>> index b79bcd2..1efe07f 100644 >>> --- a/gdb/i386-tdep.c >>> +++ b/gdb/i386-tdep.c >>> @@ -5172,6 +5172,19 @@ reswitch: >>> break; >>> /* lgdt */ >>> case 2: >>> + if (ir.mod == 3) >>> + { >>> + /* xgetbv */ >>> + if (ir.rm == 0) >>> + { >>> + I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_REAX_REGNUM); >>> + I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_REDX_REGNUM); >>> + break; >>> + } >>> + /* xsetbv */ >>> + else if (ir.rm == 1) >>> + break; >>> + } >>> /* lidt */ >>> case 3: >>> if (ir.mod == 3) >> Jiang (is that how you would like to be addressed?) >> >> This change looks OK to me in principle, but I'm not qualified >> to judge its technical correctness. I would like to get Hui >> Zhu's opinion. >> >> Nice job on the formatting and coding conventions! >> ;-) >> >> Michael >> >> >> >> >> > > >