From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11764 invoked by alias); 9 Oct 2009 22:26:59 -0000 Received: (qmail 11754 invoked by uid 22791); 9 Oct 2009 22:26:58 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Oct 2009 22:26:55 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 9441313010; Fri, 9 Oct 2009 15:26:53 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost3.vmware.com (Postfix) with ESMTP id 88A5BCD979; Fri, 9 Oct 2009 15:26:53 -0700 (PDT) Message-ID: <4ACFB7AB.6030708@vmware.com> Date: Fri, 09 Oct 2009 22:26:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Jiang Jilin CC: Hui Zhu , gdb-patches ml Subject: Re: [PATCH] Add xgetbv/xsetbv instructions support for precord. References: <> <1255095434-30271-1-git-send-email-freephp@gmail.com> In-Reply-To: <1255095434-30271-1-git-send-email-freephp@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00196.txt.bz2 Jiang Jilin wrote: > 2009-10-09 Jiang Jilin > > * i386-tdep.c (i386_process_record): Add xgetbv/xsetbv instructions support > --- > gdb/i386-tdep.c | 13 +++++++++++++ > 1 files changed, 13 insertions(+), 0 deletions(-) > > diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c > index b79bcd2..1efe07f 100644 > --- a/gdb/i386-tdep.c > +++ b/gdb/i386-tdep.c > @@ -5172,6 +5172,19 @@ reswitch: > break; > /* lgdt */ > case 2: > + if (ir.mod == 3) > + { > + /* xgetbv */ > + if (ir.rm == 0) > + { > + I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_REAX_REGNUM); > + I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_REDX_REGNUM); > + break; > + } > + /* xsetbv */ > + else if (ir.rm == 1) > + break; > + } > /* lidt */ > case 3: > if (ir.mod == 3) Jiang (is that how you would like to be addressed?) This change looks OK to me in principle, but I'm not qualified to judge its technical correctness. I would like to get Hui Zhu's opinion. Nice job on the formatting and coding conventions! ;-) Michael