From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30968 invoked by alias); 25 Sep 2009 19:16:43 -0000 Received: (qmail 30959 invoked by uid 22791); 25 Sep 2009 19:16:41 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_14 X-Spam-Check-By: sourceware.org Received: from shell4.bayarea.net (HELO shell4.bayarea.net) (209.128.82.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Sep 2009 19:16:37 +0000 Received: (qmail 13272 invoked from network); 25 Sep 2009 12:16:35 -0700 Received: from 209-128-106-254.bayarea.net (HELO redwood.eagercon.com) (209.128.106.254) by shell4.bayarea.net with SMTP; 25 Sep 2009 12:16:34 -0700 Message-ID: <4ABD1710.8040708@eagercon.com> Date: Fri, 25 Sep 2009 19:16:00 -0000 From: Michael Eager User-Agent: Thunderbird 2.0.0.23 (X11/20090825) MIME-Version: 1.0 To: Eli Zaretskii CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Add support for Xilinx MicroBlaze References: <4ABA69CE.5040707@eagercon.com> <83y6o3tmjl.fsf@gnu.org> In-Reply-To: <83y6o3tmjl.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00815.txt.bz2 Eli Zaretskii wrote: >> Date: Wed, 23 Sep 2009 11:32:46 -0700 >> From: Michael Eager >> >> Attached is a revised patch which adds support for the >> Xilinx MicroBlaze. I believe that I've addressed all >> of the previous comments. > > Thanks. And sorry for the delay ion reviewing your patch. Thanks for the review. I'll fix these issues and resubmit. Sorry this is taking so much back-and-forth. > >> * microblaze-linux-tdep.c: New. >> * microblaze-rom.c: New. >> * microblaze-tdep.c: New. >> * microblaze-tdep.h: New. > > Please add the necessary tweaks for these new files to > gdb/config/djgpp/fnchange.lst. They will clash after 8+3 truncation. > >> +@code{xmd} uses port @code{1234}. (While it is possible to change > ^^ > Two spaces between sentences, please. > >> +@item target remote XMD-HOST:1234 >> +Use this command to connect to the target if it is connected to @code{xmd} >> +running on a different system named @code{XMD-HOST}. > > Please use "@var{xmd-host}" instead of a literal upper-case XMD-HOST. > @var is what should be used in Texinfo for identifiers that stand for > something else, in this case an actual host name. > >> + /* printf("microblaze_analyze_prologue (pc = 0x%8.8x, " >> + "current_pc = 0x%8.8x, cache = 0x%8.8x)\n", >> + (int) pc, (int) current_pc, (int) cache); */ > > I believe we don't like dead code in GDB sources. > >> + /* Spill register */ > > Comments should have a period and 2 blanks at their end. > >> + cache->register_offsets[rd] = imm - cache->framesize; >> + /* reg spilled after updating */ > > Strange formatting of a comment, and indentation seems wrong. > >> + /* We have a frame pointer. Note >> + the register which is acting as the frame pointer. */ > > Please reformat whitespace here: the first line is broken too early. > >> + switch (TYPE_LENGTH(type)) > > I believe GNU standards call for a space before the left paren. > >> + default: >> + printf_filtered("Fatal error: unsupported return value size " >> + "requested (%s @ %d)\n", __FILE__, __LINE__); > > Shouldn't you call `fatal' here? > > In any case, messages presented to the user should be in _(), to be > translatable (the debug messages are exempt from this rule). > >> + /* Debug this files internals. */ >> + add_setshow_zinteger_cmd ("microblaze", class_maintenance, >> + µblaze_debug, _("\ >> +Set microblaze debugging."), _("\ >> +Show microblaze debugging."), _("\ >> +When non-zero, microblaze specific debugging is enabled."), >> + NULL, >> + NULL, >> + &setdebuglist, &showdebuglist); > > This command should be documented in the user manual. > >> --- gdb/gdb/NEWS 2009-09-06 10:14:42.000000000 -0700 >> +++ mb-gdb/gdb/NEWS 2009-09-23 10:41:55.000000000 -0700 >> @@ -442,6 +442,11 @@ Lattice Mico32 lm32-* >> x86 DICOS i[34567]86-*-dicos* >> x86_64 DICOS x86_64-*-dicos* >> S+core 3 score-*-* >> +Xilinx MicroBlaze microblaze-*-* >> + >> +* New Simulators >> + >> +Xilinx MicroBlaze microblaze > > The patch for NEWS is fine. > > Thanks. > -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077