From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13866 invoked by alias); 14 Sep 2009 23:56:42 -0000 Received: (qmail 13858 invoked by uid 22791); 14 Sep 2009 23:56:41 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Sep 2009 23:56:37 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8ENuZ7I011465 for ; Mon, 14 Sep 2009 19:56:35 -0400 Received: from [IPv6:::1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n8ENuW4X001415 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 14 Sep 2009 19:56:34 -0400 Message-ID: <4AAED830.5080909@redhat.com> Date: Mon, 14 Sep 2009 23:56:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [RFA] dwarf2_physname References: <4A9C358E.2050904@redhat.com> <4A9C54F6.1000909@eagercon.com> <4A9C5A66.7060609@redhat.com> <20090901221122.GA24658@caradoc.them.org> <4A9DADB6.2090508@redhat.com> <20090901234212.GB32355@caradoc.them.org> <4AAE8DDB.3060005@redhat.com> <20090914224754.GA7012@caradoc.them.org> In-Reply-To: <20090914224754.GA7012@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00468.txt.bz2 On 09/14/2009 03:47 PM, Daniel Jacobowitz wrote: > I'm really sorry about the rathole. I expected you'd just ask me to > do it... you're correct that you are going to get a lot of failures > with RealView. I have patches for some of the worst, both in > testsuite patterns and in GDB proper. Part of the reason I haven't > posted them yet, though, is this exact issue - one of the patches in > our tree for RealView support is the stone-age ancestor of your > patches :-) > > ICC, though, I'm pretty surprised; we get bug reports about people > using ICC once in a while, and I thought someone had tested it... > > Now that you've gone to the trouble, though, let's make the most of > your work. Could I persuade you to put the wrappers you needed and > where to get appropriate compilers onto the GDB wiki? Yeah, I'll work on that immediately. Of course, that means I have to take out all the, umm, colorful language that litters my scripts. O:-) > Ouch. Though, why does this make life difficult for the debugger? > The problem of THIS not being artificial I've seen before - I think > RealView has the same problem; I may have a patch to work around it - > but I'm not sure why we care about the name of the parameter in the > declaration. The problem is that now we are appending the arguments to the "linkage name" that we are computing. So when the dwarf reader sees this, it outputs "foo::foo (foo *)" instead of "foo::foo ()". This messes up symbol searching in some very interesting ways. >> Is there anything else you want me to investigate? > > No, I'm happy. Is this patch still current? If so, I'll review it > tonight. Yes, the patch still applies to CVS HEAD. Let me know if you need anything else. Keith