From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25747 invoked by alias); 13 Sep 2009 00:29:10 -0000 Received: (qmail 25739 invoked by uid 22791); 13 Sep 2009 00:29:10 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 13 Sep 2009 00:29:04 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id BBE6544004; Sat, 12 Sep 2009 17:29:00 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost3.vmware.com (Postfix) with ESMTP id B1855CD915; Sat, 12 Sep 2009 17:29:00 -0700 (PDT) Message-ID: <4AAC3C43.2030807@vmware.com> Date: Sun, 13 Sep 2009 00:29:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Joel Brobecker CC: Hui Zhu , gdb-patches ml Subject: Re: [RFA] Make the prec support signal better[0/4] References: <4AA95648.10605@vmware.com> <20090910232952.GP20694@adacore.com> <4AAAAD82.50300@vmware.com> <20090911234317.GT20694@adacore.com> <4AAAEE45.3070504@vmware.com> <20090912010230.GU20694@adacore.com> In-Reply-To: <20090912010230.GU20694@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00378.txt.bz2 Joel Brobecker wrote: >> No no, I've already contributed more than my share of ugliness >> to the world. PROTOTYPES removed. ;-) > > OK (thanks!)! It looks much more readable, now. However, you forgot to > update the functions that have no argument (it should be "(void)" > rather than "()"). I promise this is the last thing I'm seeing! :-). > > The rest looks great to me. > Done and committed. Thanks.