From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9391 invoked by alias); 8 Sep 2009 16:57:30 -0000 Received: (qmail 9307 invoked by uid 22791); 8 Sep 2009 16:57:27 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Sep 2009 16:57:17 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 545422A00A; Tue, 8 Sep 2009 09:57:16 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost4.vmware.com (Postfix) with ESMTP id 48EB9C9ACF; Tue, 8 Sep 2009 09:57:16 -0700 (PDT) Message-ID: <4AA68C92.7070905@vmware.com> Date: Tue, 08 Sep 2009 16:57:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Hui Zhu CC: Joel Brobecker , "gdb-patches@sourceware.org" Subject: Re: [RFA] let record_resume fail immediately on error References: <4AA5D713.1060305@vmware.com> <20090908065843.GO30677@adacore.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00201.txt.bz2 Hui Zhu wrote: > On Tue, Sep 8, 2009 at 15:25, Hui Zhu wrote: >> If GDB call error in record_resume, user cannot keep debug the inferior. >> >> Hui >> >> On Tue, Sep 8, 2009 at 15:23, Hui Zhu wrote: >>> The "record_resume_error" in gdb-cvs is to make user after get a error >>> of record_message, they can "record stop" close the record and keep >>> debug the inferior. >>> >>> Thanks, >>> Hui >>> >>> On Tue, Sep 8, 2009 at 14:58, Joel Brobecker wrote: >>>>> if (!RECORD_IS_REPLAY) >>>>> { >>>>> if (do_record_message (get_current_regcache ())) >>>>> - { >>>>> - record_resume_error = 0; >>>>> - } >>>>> - else >>>>> - { >>>>> - record_resume_error = 1; >>>>> - return; >>>>> - } >>>>> + internal_error (__FILE__, __LINE__, >>>>> + _("record_resume: do_record_message failed.")); >>>>> + >>>> Forgive me if I'm wrong, as I don't know the record.c code at all, but >>>> I cannot help but think that the internal_error is suspicious here. >>>> Why is this an internal_error? >>>> >>>> -- >>>> Joel >>>> > > Hi guys, > > I make a patch that make "record_resume_error" work better. I did > some test. It seems better than before. Could you explain what you mean by better? I mean, what behavior are you looking for here? Here is the behavior that I see --- I am making a recording, I say "continue", and after a while this "record_resume_error" is triggered, and gdb stops and says "No more reverse-execution history." I would never expect to see that message during recording. > 2009-09-08 Hui Zhu > > * record.c (record_wait): Change TARGET_SIGNAL_ABRT to > TARGET_SIGNAL_0. > --- > record.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/record.c > +++ b/record.c > @@ -590,7 +590,7 @@ record_wait (struct target_ops *ops, > { > /* If record_resume get error, return directly. */ > status->kind = TARGET_WAITKIND_STOPPED; > - status->value.sig = TARGET_SIGNAL_ABRT; > + status->value.sig = TARGET_SIGNAL_0; > return inferior_ptid; > }