From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1161 invoked by alias); 8 Sep 2009 16:54:25 -0000 Received: (qmail 1122 invoked by uid 22791); 8 Sep 2009 16:54:23 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Sep 2009 16:54:10 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 2AC30130C9; Tue, 8 Sep 2009 09:54:09 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost4.vmware.com (Postfix) with ESMTP id 07389C9BBC; Tue, 8 Sep 2009 09:54:09 -0700 (PDT) Message-ID: <4AA68BD7.6030301@vmware.com> Date: Tue, 08 Sep 2009 16:54:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Hui Zhu CC: Joel Brobecker , "gdb-patches@sourceware.org" Subject: Re: [RFA] let record_resume fail immediately on error References: <4AA5D713.1060305@vmware.com> <20090908065843.GO30677@adacore.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00200.txt.bz2 Hui Zhu wrote: > If GDB call error in record_resume, user cannot keep debug the inferior. OK, what would you want to have happen, if record_resume fails? You have to assume that you can't keep recording, so you would have to at least drop out of "target record" and back to "target beneath". > On Tue, Sep 8, 2009 at 15:23, Hui Zhu wrote: >> The "record_resume_error" in gdb-cvs is to make user after get a error >> of record_message, they can "record stop" close the record and keep >> debug the inferior. >> >> Thanks, >> Hui >> >> On Tue, Sep 8, 2009 at 14:58, Joel Brobecker wrote: >>>> if (!RECORD_IS_REPLAY) >>>> { >>>> if (do_record_message (get_current_regcache ())) >>>> - { >>>> - record_resume_error = 0; >>>> - } >>>> - else >>>> - { >>>> - record_resume_error = 1; >>>> - return; >>>> - } >>>> + internal_error (__FILE__, __LINE__, >>>> + _("record_resume: do_record_message failed.")); >>>> + >>> Forgive me if I'm wrong, as I don't know the record.c code at all, but >>> I cannot help but think that the internal_error is suspicious here. >>> Why is this an internal_error? >>> >>> -- >>> Joel >>>