From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-66603-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23734 invoked by alias); 8 Sep 2009 16:50:51 -0000
Received: (qmail 23700 invoked by uid 22791); 8 Sep 2009 16:50:51 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Sep 2009 16:50:42 +0000
Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) 	by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 5060A130C6; 	Tue,  8 Sep 2009 09:50:39 -0700 (PDT)
Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) 	by mailhost4.vmware.com (Postfix) with ESMTP id 45FAEC9B90; 	Tue,  8 Sep 2009 09:50:39 -0700 (PDT)
Message-ID: <4AA68B05.5070909@vmware.com>
Date: Tue, 08 Sep 2009 16:50:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 1.5.0.12 (X11/20080411)
MIME-Version: 1.0
To: Joel Brobecker <brobecker@adacore.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,   Hui Zhu <teawater@gmail.com>
Subject: Re: [RFA] let record_resume fail immediately on error
References: <4AA5D713.1060305@vmware.com> <20090908065843.GO30677@adacore.com>
In-Reply-To: <20090908065843.GO30677@adacore.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-09/txt/msg00198.txt.bz2

Joel Brobecker wrote:
>>    if (!RECORD_IS_REPLAY)
>>      {
>>        if (do_record_message (get_current_regcache ()))
>> -        {
>> -          record_resume_error = 0;
>> -        }
>> -      else
>> -        {
>> -          record_resume_error = 1;
>> -          return;
>> -        }
>> +	internal_error (__FILE__, __LINE__, 
>> +			_("record_resume: do_record_message failed."));
>> +
> 
> Forgive me if I'm wrong, as I don't know the record.c code at all, but
> I cannot help but think that the internal_error is suspicious here.
> Why is this an internal_error?

I'm certainly open to alternatives.

It's some kind of error, because we're in the record phase, and
"do_record_message" (which records the side effects of the instruction)
returned failure.  Most likely it hit some resource limit, but it is
possible that something else happened like trying to read from an
unreadable memory location.

You think simple error would be better?