RE: GDB MI Reverse Commands added [3 of 3]

Jakob Engblom
2009-12-16T08:48:17Z

> It does not seem like any of them were addressed. When they are addressed,
> this patch is OK. Because the only non-mechanical change is replacement of
> FIXME with a suitable comment, and reverse-mode experts are in much better
> position to decide if a comment captures the behaviour properly, I don't
> think I have to re-review any revision of this patch -- please commit directly
> when you think it's ready.

I think they are. The latest file that Michael Snyder attached:

* Is called "mi-reverse.exp"

* Does use set MIFLAGS "-i=mi"

* And the FIXME comment has been replaced with a better comment:

# Test exec-reverse-next
# It takes two steps to get back to the previous line,
# as the first step moves us to the start of the current line,
# and the one after that moves back to the previous line.

mi_execute_to "exec-next --reverse 2" \
"end-stepping-range" "main" "" \
"basics.c" $line_main_hello "" \
"reverse next to get over the call to do_nothing"

So it looks to me like all the comments have been addressed, in the patch in the
email at http://sourceware.org/ml/gdb-patches/2009-12/msg00199.html .

Best regards,

/jakob

_______________________________________________________

Jakob Engblom, PhD, Technical Marketing Manager

Virtutech                   Direct: +46 8 690 07 47
Drottningholmsvägen 22      Mobile: +46 709 242 646
11243 Stockholm             Web:    www.virtutech.com
Sweden
________________________________________________________