From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16767 invoked by alias); 6 Sep 2009 03:37:32 -0000 Received: (qmail 16756 invoked by uid 22791); 6 Sep 2009 03:37:31 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_37,SARE_SUB_OBFU_Q1 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 06 Sep 2009 03:37:27 +0000 Received: from jupiter.vmware.com (mailhost5.vmware.com [10.16.68.131]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 7F6C84900C; Sat, 5 Sep 2009 20:37:23 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by jupiter.vmware.com (Postfix) with ESMTP id 73423DC05C; Sat, 5 Sep 2009 20:37:23 -0700 (PDT) Message-ID: <4AA32E36.1020709@vmware.com> Date: Sun, 06 Sep 2009 03:37:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Eli Zaretskii CC: Pedro Alves , "gdb-patches@sourceware.org" , "jakob@virtutech.com" , "glaw@undo-software.com" Subject: Re: [PATCH] Add 'reverse' capability query to remote protocol (qSupported). References: <4A9C2AD3.5070904@vmware.com> <200909011644.14035.pedro@codesourcery.com> <837hwia96c.fsf@gnu.org> In-Reply-To: <837hwia96c.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------080103010207080502050004" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00140.txt.bz2 This is a multi-part message in MIME format. --------------080103010207080502050004 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 406 Eli Zaretskii wrote: >> From: Pedro Alves >> Date: Tue, 1 Sep 2009 16:44:13 +0100 >> Cc: Michael Snyder , Jakob Engblom , Greg Law >> >> Your patch also needs docs and NEWS entries, BTW. > > And a patch for the manual documenting the new packets, no? New diff incorporating comments and adding docs and NEWS. --------------080103010207080502050004 Content-Type: text/plain; name="qSupported-3.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="qSupported-3.txt" Content-length: 4664 Index: remote.c =================================================================== RCS file: /cvs/src/src/gdb/remote.c,v retrieving revision 1.370 diff -u -p -r1.370 remote.c --- remote.c 18 Aug 2009 16:17:16 -0000 1.370 +++ remote.c 6 Sep 2009 03:33:51 -0000 @@ -1000,6 +1000,8 @@ enum { PACKET_qXfer_siginfo_write, PACKET_qAttached, PACKET_ConditionalTracepoints, + PACKET_bc, + PACKET_bs, PACKET_MAX }; @@ -3051,6 +3053,10 @@ static struct protocol_feature remote_pr PACKET_qXfer_siginfo_write }, { "ConditionalTracepoints", PACKET_DISABLE, remote_cond_tracepoint_feature, PACKET_ConditionalTracepoints }, + { "ReverseContinue", PACKET_DISABLE, remote_supported_packet, + PACKET_bc }, + { "ReverseStep", PACKET_DISABLE, remote_supported_packet, + PACKET_bs }, }; static void @@ -3818,6 +3824,14 @@ remote_resume (struct target_ops *ops, if (info_verbose && siggnal != TARGET_SIGNAL_0) warning (" - Can't pass signal %d to target in reverse: ignored.\n", siggnal); + + if (step + && remote_protocol_packets[PACKET_bs].support == PACKET_DISABLE) + error ("Remote reverse-step not supported."); + if (!step + && remote_protocol_packets[PACKET_bc].support == PACKET_DISABLE) + error ("Remote reverse-continue not supported."); + strcpy (buf, step ? "bs" : "bc"); } else if (siggnal != TARGET_SIGNAL_0) @@ -8730,12 +8744,14 @@ remote_command (char *args, int from_tty help_list (remote_cmdlist, "remote ", -1, gdb_stdout); } -static int remote_target_can_reverse = 1; - static int remote_can_execute_reverse (void) { - return remote_target_can_reverse; + if (remote_protocol_packets[PACKET_bs].support == PACKET_ENABLE + || remote_protocol_packets[PACKET_bc].support == PACKET_ENABLE) + return 1; + else + return 0; } static int @@ -9165,6 +9181,12 @@ Show the maximum size of the address (in "qGetTLSAddr", "get-thread-local-storage-address", 0); + add_packet_config_cmd (&remote_protocol_packets[PACKET_bc], + "bc", "reverse-continue", 0); + + add_packet_config_cmd (&remote_protocol_packets[PACKET_bs], + "bs", "reverse-step", 0); + add_packet_config_cmd (&remote_protocol_packets[PACKET_qSupported], "qSupported", "supported-packets", 0); Index: NEWS =================================================================== RCS file: /cvs/src/src/gdb/NEWS,v retrieving revision 1.328 diff -u -p -r1.328 NEWS --- NEWS 31 Aug 2009 20:18:45 -0000 1.328 +++ NEWS 6 Sep 2009 03:33:51 -0000 @@ -309,6 +309,14 @@ show remote write-siginfo-object Control use of remote protocol `qXfer:siginfo:write' (write-siginfo-object) packet. +set remote reverse-continue +show remote reverse-continue + Control use of remote protocol 'bc' (reverse-continue) packet. + +set remote reverse-step +show remote reverse-step + Control use of remote protocol 'bs' (reverse-step) packet. + set displaced-stepping show displaced-stepping Control displaced stepping mode. Displaced stepping is a way to Index: doc/gdb.texinfo =================================================================== RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v retrieving revision 1.620 diff -u -p -r1.620 gdb.texinfo --- doc/gdb.texinfo 1 Sep 2009 18:48:58 -0000 1.620 +++ doc/gdb.texinfo 6 Sep 2009 03:33:51 -0000 @@ -27493,16 +27493,18 @@ breakpoint at @var{addr}. Don't use this packet. Use the @samp{Z} and @samp{z} packets instead (@pxref{insert breakpoint or watchpoint packet}). -@item bc @cindex @samp{bc} packet +@anchor{bc} +@item bc Backward continue. Execute the target system in reverse. No parameter. @xref{Reverse Execution}, for more information. Reply: @xref{Stop Reply Packets}, for the reply specifications. -@item bs @cindex @samp{bs} packet +@anchor{bs} +@item bs Backward single step. Execute one instruction in reverse. No parameter. @xref{Reverse Execution}, for more information. @@ -28746,6 +28748,16 @@ These are the currently defined stub fea @tab @samp{-} @tab No +@item @samp{ReverseContinue} +@tab No +@tab @samp{+} +@tab No + +@item @samp{ReverseStep} +@tab No +@tab @samp{+} +@tab No + @end multitable These are the currently defined stub features, in more detail: @@ -28827,6 +28839,14 @@ The remote stub understands the @samp{qX The remote stub accepts and implements conditional expressions defined for tracepoints (@pxref{Tracepoint Conditions}). +@item ReverseContinue +The remote stub accepts and implements the reverse continue packet +(@pxref{bc}). + +@item ReverseStep +The remote stub accepts and implements the reverse step packet +(@pxref{bs}). + @end table @item qSymbol:: --------------080103010207080502050004--