Re: GDB MI Reverse Commands added [1 of 3]

Tom Tromey
2009-08-31T20:02:11Z

Michael> Group, this patch seemed to have gotten a little munged in
Michael> email. I've taken the liberty of re-diffing it, to restore
Michael> white space context.

Thanks.

I have a few nits to pick.

Jakob> + if (argc > 0 && strcmp(argv[0], "--reverse") == 0)

Space before (".
There are a number of these.

Jakob> +/* continue in reverse direction:
Jakob> + XXX: code duplicated from reverse.c */

We're trying not to add new FIXME-type comments.

In this particular case I think it is ok to just drop the comment.
However, if you prefer, I think you could add a new exported
"make_cleanup_..." function in reverse.c.

Tom