From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32262 invoked by alias); 28 Aug 2009 01:44:52 -0000 Received: (qmail 32253 invoked by uid 22791); 28 Aug 2009 01:44:51 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Aug 2009 01:44:47 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 1CED246002; Thu, 27 Aug 2009 18:44:46 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost4.vmware.com (Postfix) with ESMTP id 13547C9A1C; Thu, 27 Aug 2009 18:44:46 -0700 (PDT) Message-ID: <4A9736B4.4020008@vmware.com> Date: Fri, 28 Aug 2009 01:57:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Hui Zhu CC: Jiang Jilin , gdb-patches ml Subject: Re: [PATCH] fixed the memory leak in record.c References: <1251342694-17525-1-git-send-email-freephp@gmail.com> In-Reply-To: Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00504.txt.bz2 Hui Zhu wrote: > On Thu, Aug 27, 2009 at 13:35, Hui Zhu wrote: >> On Thu, Aug 27, 2009 at 11:11, Jiang Jilin wrote: >>> * record.c (record_list_release_next) : fixed memory leak when record type is record_reg >>> >>> Signed-off-by: Jiang Jilin >>> --- >>> gdb/record.c | 7 ++++--- >>> 1 files changed, 4 insertions(+), 3 deletions(-) >>> >>> diff --git a/gdb/record.c b/gdb/record.c >>> index 8afca6b..07e9e80 100644 >>> --- a/gdb/record.c >>> +++ b/gdb/record.c >>> @@ -158,9 +158,10 @@ record_list_release_next (void) >>> { >>> rec = tmp->next; >>> if (tmp->type == record_reg) >>> - record_insn_num--; >>> - else if (tmp->type == record_reg) >>> - xfree (tmp->u.reg.val); >>> + { >>> + record_insn_num--; >>> + xfree (tmp->u.reg.val); >>> + } >>> else if (tmp->type == record_mem) >>> xfree (tmp->u.mem.val); >>> xfree (tmp); >>> -- >>> 1.5.4.3 >>> >>> > > Hi Michael, > > Could you please help me review this patch? Yes, I think it looks fine. Please commit. > Following is my patch: > >> Cool. Thanks for find it out. :) >> But this patch is not OK. This record_reg should be record_end. >> >> I make a patch for it. >> >> Thanks, >> Hui >> >> 2009-08-27 Hui Zhu >> >> * record.c (record_list_release_next): Change the first >> record_reg to record_end. >> > --- > record.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/record.c > +++ b/record.c > @@ -157,7 +157,7 @@ record_list_release_next (void) > while (tmp) > { > rec = tmp->next; > - if (tmp->type == record_reg) > + if (tmp->type == record_end) > record_insn_num--; > else if (tmp->type == record_reg) > xfree (tmp->u.reg.val);