From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9613 invoked by alias); 26 Aug 2009 07:21:45 -0000 Received: (qmail 9605 invoked by uid 22791); 26 Aug 2009 07:21:44 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-bw0-f207.google.com (HELO mail-bw0-f207.google.com) (209.85.218.207) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Aug 2009 07:21:34 +0000 Received: by bwz3 with SMTP id 3so2361998bwz.26 for ; Wed, 26 Aug 2009 00:21:29 -0700 (PDT) Received: by 10.102.249.10 with SMTP id w10mr3303480muh.49.1251271289204; Wed, 26 Aug 2009 00:21:29 -0700 (PDT) Received: from yakj.usersys.redhat.com ([85.93.118.17]) by mx.google.com with ESMTPS id n10sm3589670mue.19.2009.08.26.00.21.28 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 26 Aug 2009 00:21:28 -0700 (PDT) Message-ID: <4A94E277.70205@gnu.org> Date: Wed, 26 Aug 2009 12:04:00 -0000 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3 MIME-Version: 1.0 To: Ralf Wildenhues CC: "Frank Ch. Eigler" , Tom Tromey , gdb-patches@sources.redhat.com Subject: Re: fixup SIM_CHECK_* References: <20090815112928.GB5396@gmx.de> <20090815113302.GC20172@gmx.de> <20090818184349.GE30742@gmx.de> <20090825195545.GC5034@gmx.de> In-Reply-To: <20090825195545.GC5034@gmx.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00439.txt.bz2 On 08/25/2009 09:55 PM, Ralf Wildenhues wrote: > * Frank Ch. Eigler wrote on Wed, Aug 19, 2009 at 09:34:37PM CEST: >> According to the FIXME note in that file, please excise SIM_CHECK_* >> altogether if it has been mooted by a modern autoconf. > > This was still left TODO. Of course, I managed to actually commit a > patch, that would not expand AC_CHECK_MEMBERS correctly, as that uses > _$0_BODY internally, and $0 is still SIM_CHECK_MEMBER (Paolo, it's ugly > to have to remember this, so we maybe shouldn't use m4_defn so much): Hey, Eric (Blake) is the big optimizer in Autoconf-land, not me. :-) I agree with you, though of course I don't like this kind of relying on Autoconf internals. The patch seems fine. Paolo