From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14684 invoked by alias); 25 Aug 2009 17:11:16 -0000 Received: (qmail 14667 invoked by uid 22791); 25 Aug 2009 17:11:15 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from qnxmail.qnx.com (HELO qnxmail.qnx.com) (209.226.137.76) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 25 Aug 2009 17:11:04 +0000 Received: from Nebula.ott.qnx.com (nebula.ott.qnx.com [10.42.3.30]) by hub.ott.qnx.com (8.9.3/8.9.3) with ESMTP id NAA10301; Tue, 25 Aug 2009 13:10:56 -0400 Received: from [127.0.0.1] ([10.42.100.129]) by Nebula.ott.qnx.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 25 Aug 2009 13:11:02 -0400 Message-ID: <4A941AFC.5040100@qnx.com> Date: Tue, 25 Aug 2009 17:20:00 -0000 From: Aleksandar Ristovski User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Pedro Alves CC: gdb-patches@sourceware.org Subject: Re: [patch] -Wall patches References: <200908241234.43838.pedro@codesourcery.com> In-Reply-To: <200908241234.43838.pedro@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00421.txt.bz2 Pedro Alves wrote: > I was quickly skimming through the patch, and I saw this: > > On Thursday 06 August 2009 21:17:25, Aleksandar Ristovski wrote: >> --- src0/gdb/valops.c 2009-07-31 14:43:27.000000000 -0400 >> +++ src1/gdb/valops.c 2009-08-06 09:04:20.000000000 -0400 >> @@ -270,7 +270,6 @@ value_cast_structs (struct type *type, s >> struct value * >> value_cast_pointers (struct type *type, struct value *arg2) >> { >> - struct type *type1 = check_typedef (type); >> struct type *type2 = check_typedef (value_type (arg2)); >> struct type *t1 = check_typedef (TYPE_TARGET_TYPE (type)); >> struct type *t2 = check_typedef (TYPE_TARGET_TYPE (type2)); >> @@ -866,6 +865,9 @@ value_assign (struct value *toval, struc >> value_reg = VALUE_REGNUM (toval); >> >> if (!frame) >> + frame = get_current_frame (); >> + >> + if (!frame) >> error (_("Value being assigned to is no longer active.")); >> > > Looks like it was accidentally included. It looks like the > workaround for "set reg=foo", when there's no valid frame id. > Yes, it was included by accident. And I think the workaround din't work for me (for whatever reason)... but that's another story. -- Aleksandar Ristovski QNX Software Systems