Re: [patch 2/2] Perform a namespace lookup at every block level

Tom Tromey
2009-12-21T21:55:27Z

>>>>> "Sami" == Sami Wagiaalla <swagiaal@redhat.com> writes:

Sami> Updating patch because of changes in patch 1/2
Sami> 2009-11-16 Sami Wagiaalla <swagiaal@redhat.com>
Sami> * cp-namespace.c (cp_lookup_symbol_namespace): Added
Sami> search_parent argument.
Sami> (cp_add_using): Initialize 'searched' field.
Sami> (cp_copy_usings): Copy searched field.
Sami> * cp-support.h: Add 'searched' field to using_direct struct.
Sami> (cp_lookup_symbol_imports): Ditto.
Sami> * cp-namespace.c (cp_lookup_symbol_imports): Ditto.
Sami> Perform recursive search.
Sami> Implement non parent search.
Sami> * valops.c (value_maybe_namespace_elt): Updated.

This is nearly ok.

Note that the patch got a little mangled, and this resubmission was
missing the changes in testsuite/.

Sami> 2009-11-16 Sami Wagiaalla <swagiaal@redhat.com>
Sami> * gdb.cp/namespace-stress.exp: New test.
Sami> * gdb.cp/namespace-stress.cc: New test program.
Sami> * gdb.cp/namespace-recursive.exp: New test.
Sami> * gdb.cp/namespace-recursive.cc: New test program.
Sami> * gdb.cp/namespace-stress.exp: New test.
Sami> * gdb.cp/namespace-stress.cc: New test program.

We're mostly following 8.3 rules, so I would suggest renaming these to
"ns-*".

Also, in an archer fix you had namespace-stress-declaration... what
happened to that? The corresponding code patch seems to include
reset_directive_searched:
http://sourceware.org/ml/archer-commits/2009-q4/msg00094.html

Speaking of which, reset_directive_searched is not mentioned in the
ChangeLog.

Tom