From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21084 invoked by alias); 12 Aug 2009 23:02:45 -0000 Received: (qmail 20927 invoked by uid 22791); 12 Aug 2009 23:02:43 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Aug 2009 23:02:37 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 3A53653012; Wed, 12 Aug 2009 16:02:36 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost3.vmware.com (Postfix) with ESMTP id 31C11CD91B; Wed, 12 Aug 2009 16:02:36 -0700 (PDT) Message-ID: <4A834981.5070200@vmware.com> Date: Wed, 12 Aug 2009 23:06:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Aleksandar Ristovski CC: "gdb-patches@sources.redhat.com" Subject: Re: [patch] -Wall patches References: <4A7B49C0.5070702@vmware.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00175.txt.bz2 Aleksandar Ristovski wrote: > Michael Snyder wrote: >> Aleksandar Ristovski wrote: >>> Hello, >>> >>> >>> I have internally made changes necessary to get clean compile with >>> -Wall compiler option. I tried to break down the patch to related >>> files; I am intentionally not writing a changelog since most of the >>> changes are mechanical and consist of removing unused variables, >>> several unused functions, gdb_byte/char casting. >>> >>> I would not mind if respective maintainers looked at the patches for >>> their files and committed the changes (otherwise it will be quite >>> cumbersome and somewhat overwhelming for me to keep the patch >>> applicable; not to mention change log and all). >> Your change subsumes the change that I submitted to remove >> unused variables from remote.c -- I'll hold off committing >> that change 'till we decide what to do about it. >> >> Michael >> > > I would suggest that you commit your changes, and just let > me know here that a patch from my list is not relevant any > more. E.g. "Wall-remote.diff not applicable any more". There > is also Wall-tracepoint.diff which is in your domain too. OK, but I only committed the unused variable changes for remote.c. I believe your diffs contain more changes than that. Michael