Tom Tromey wrote:
>>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
> 
> A few little nits in this patch.  Most of these appear more than once.
> 
> Michael> +extern bfd *
> Michael> +create_gcore_bfd (char *filename)
> Michael>  {
> 
> Don't use "extern" on definitions.
>  
> Michael> +static bfd_vma
> Michael> +call_target_sbrk (int sbrk_arg)
> 
> New functions should have an explanatory comment.
> 
> Michael> +#include <fcntl.h>
> Michael> +#ifndef O_BINARY
> Michael> +#define O_BINARY 0
> Michael> +#endif
> Michael> +
> Michael> +#include "regcache.h"
> Michael> +#include "regset.h"
> 
> I think adding #includes in the middle of a file is ugly.
> 
> Also, I think the O_BINARY define isn't needed -- it looks to me that
> defs.h does this.

Tom, thanks for the review.
Added gcore.h to export those externs, and moved one decl into 
inferior.h (always meant to do that for linux-fork).