From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-65897-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23830 invoked by alias); 6 Aug 2009 21:24:32 -0000
Received: (qmail 23821 invoked by uid 22791); 6 Aug 2009 21:24:31 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Aug 2009 21:24:26 +0000
Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) 	by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 350501343E; 	Thu,  6 Aug 2009 14:24:24 -0700 (PDT)
Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) 	by mailhost4.vmware.com (Postfix) with ESMTP id 2B30FC9A3A; 	Thu,  6 Aug 2009 14:24:24 -0700 (PDT)
Message-ID: <4A7B49C0.5070702@vmware.com>
Date: Fri, 07 Aug 2009 03:05:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 1.5.0.12 (X11/20080411)
MIME-Version: 1.0
To: Aleksandar Ristovski <aristovski@qnx.com>
CC: "gdb-patches@sources.redhat.com" <gdb-patches@sources.redhat.com>
Subject: Re: [patch] -Wall patches
References: <h5fdom$ibb$1@ger.gmane.org>
In-Reply-To: <h5fdom$ibb$1@ger.gmane.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-08/txt/msg00096.txt.bz2

Aleksandar Ristovski wrote:
> Hello,
> 
> 
> I have internally made changes necessary to get clean 
> compile with -Wall compiler option. I tried to break down 
> the patch to related files; I am intentionally not writing a 
> changelog since most of the changes are mechanical and 
> consist of removing unused variables, several unused 
> functions, gdb_byte/char casting.
> 
> I would not mind if respective maintainers looked at the 
> patches for their files and committed the changes (otherwise 
> it will be quite cumbersome and somewhat overwhelming for me 
> to keep the patch applicable; not to mention change log and 
> all).

Your change subsumes the change that I submitted to remove
unused variables from remote.c -- I'll hold off committing
that change 'till we decide what to do about it.

Michael